Issue 463523003: Fix an issue with view manager init service where you had to retain a connection to the init servic…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 463523003: Fix an issue with view manager init service where you had to retain a connection to the init servic… (Closed)

Created:
6 years, 4 months ago by Ben Goodger (Google)

Modified:
6 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix an issue with view manager init service where you had to retain a connection to the init service until the window tree host was created otherwise embed calls would be dropped. R=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288993

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -72 lines)			Patch
M	mojo/examples/wm_flow/app/app.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_init_service_context.h	View		3 chunks	+22 lines, -0 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_init_service_context.cc	View	1	4 chunks	+45 lines, -11 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_init_service_impl.h	View		4 chunks	+0 lines, -25 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_init_service_impl.cc	View		2 chunks	+1 line, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/463523003/diff/1/mojo/services/view_manager/view_manager_init_service_context.cc File mojo/services/view_manager/view_manager_init_service_context.cc (right): https://codereview.chromium.org/463523003/diff/1/mojo/services/view_manager/view_manager_init_service_context.cc#newcode92 mojo/services/view_manager/view_manager_init_service_context.cc:92: ScopedVector<ConnectParams>::const_iterator it = connect_params_.begin(); nit: move into for ...

6 years, 4 months ago (2014-08-11 23:47:56 UTC) #2

Ben Goodger (Google)

6 years, 4 months ago (2014-08-12 15:52:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 288993 (presubmit successful).

Expand Messages | Collapse Messages