Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: src/heap/store-buffer.h

Issue 463523002: Move store-buffer to heap and remove some unnecessary includes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/spaces.h ('k') | src/heap/store-buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/store-buffer.h
diff --git a/src/store-buffer.h b/src/heap/store-buffer.h
similarity index 92%
rename from src/store-buffer.h
rename to src/heap/store-buffer.h
index de7be0e34ea79b90248ac660ce2d3a430f700fc2..5efd6922bcd6bc30f3a21c298761ae52beeb8513 100644
--- a/src/store-buffer.h
+++ b/src/heap/store-buffer.h
@@ -19,8 +19,7 @@ class StoreBuffer;
typedef void (*ObjectSlotCallback)(HeapObject** from, HeapObject* to);
-typedef void (StoreBuffer::*RegionCallback)(Address start,
- Address end,
+typedef void (StoreBuffer::*RegionCallback)(Address start, Address end,
ObjectSlotCallback slot_callback,
bool clear_maps);
@@ -147,12 +146,11 @@ class StoreBuffer {
void ExemptPopularPages(int prime_sample_step, int threshold);
// Set the map field of the object to NULL if contains a map.
- inline void ClearDeadObject(HeapObject *object);
+ inline void ClearDeadObject(HeapObject* object);
void IteratePointersToNewSpace(ObjectSlotCallback callback, bool clear_maps);
- void FindPointersToNewSpaceInRegion(Address start,
- Address end,
+ void FindPointersToNewSpaceInRegion(Address start, Address end,
ObjectSlotCallback slot_callback,
bool clear_maps);
@@ -161,11 +159,9 @@ class StoreBuffer {
// If either visit_pointer_region or callback can cause an allocation
// in old space and changes in allocation watermark then
// can_preallocate_during_iteration should be set to true.
- void IteratePointersOnPage(
- PagedSpace* space,
- Page* page,
- RegionCallback region_callback,
- ObjectSlotCallback slot_callback);
+ void IteratePointersOnPage(PagedSpace* space, Page* page,
+ RegionCallback region_callback,
+ ObjectSlotCallback slot_callback);
void IteratePointersInStoreBuffer(ObjectSlotCallback slot_callback,
bool clear_maps);
@@ -181,8 +177,7 @@ class StoreBuffer {
class StoreBufferRebuildScope {
public:
- explicit StoreBufferRebuildScope(Heap* heap,
- StoreBuffer* store_buffer,
+ explicit StoreBufferRebuildScope(Heap* heap, StoreBuffer* store_buffer,
StoreBufferCallback callback)
: store_buffer_(store_buffer),
stored_state_(store_buffer->store_buffer_rebuilding_enabled_),
@@ -220,7 +215,7 @@ class DontMoveStoreBufferEntriesScope {
StoreBuffer* store_buffer_;
bool stored_state_;
};
-
-} } // namespace v8::internal
+}
+} // namespace v8::internal
#endif // V8_STORE_BUFFER_H_
« no previous file with comments | « src/heap/spaces.h ('k') | src/heap/store-buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698