chrome/browser/notifications/notification_ui_manager.h - Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_ui_manager.h

Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/balloon_collection_base.h ('K') | « chrome/browser/notifications/notification_test_util.h ('k') | chrome/browser/notifications/notification_ui_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_ui_manager.h

===================================================================

--- chrome/browser/notifications/notification_ui_manager.h (revision 65581)

+++ chrome/browser/notifications/notification_ui_manager.h (working copy)

@@ -7,6 +7,7 @@

#pragma once

#include <deque>

+#include <string>

#include "base/id_map.h"

#include "base/scoped_ptr.h"

@@ -43,9 +44,13 @@

virtual void Add(const Notification& notification,

Profile* profile);

- // Removes a notification.

- virtual bool Cancel(const Notification& notification);

+ // Removes any notifications matching the supplied ID.

tfarina 2010/11/11 12:56:58 nit: maybe: the given |notification_id|?

John Gregg 2010/11/11 18:13:51 Thanks, but I think it's clear as-is.

+ virtual bool CancelById(const std::string& notification_id);

+ // Removes any notifications matching the supplied source origin

+ // (which could be an extension ID).

+ virtual bool CancelAllBySourceOrigin(const GURL& source_origin);

// Returns balloon collection.

BalloonCollection* balloon_collection() {

return balloon_collection_.get();