Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4395)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/notifications/balloon_view.cc

Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/notifications/balloon_collection_impl.cc ('k') | chrome/browser/chromeos/notifications/desktop_notifications_unittest.h » ('j') | chrome/browser/notifications/balloon_collection_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/notifications/balloon_view.cc
===================================================================
--- chrome/browser/chromeos/notifications/balloon_view.cc (revision 65581)
+++ chrome/browser/chromeos/notifications/balloon_view.cc (working copy)
@@ -300,7 +300,7 @@
// BalloonViewImpl public.
bool BalloonViewImpl::IsFor(const Notification& notification) const {
- return balloon_->notification().IsSame(notification);
+ return balloon_->notification().notification_id() == notification.notification_id();
tfarina 2010/11/11 12:56:58 nit: line > 80 characters
John Gregg 2010/11/11 18:13:51 Done.
}
void BalloonViewImpl::Activated() {
« no previous file with comments | « chrome/browser/chromeos/notifications/balloon_collection_impl.cc ('k') | chrome/browser/chromeos/notifications/desktop_notifications_unittest.h » ('j') | chrome/browser/notifications/balloon_collection_base.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698