chrome/browser/task_manager/task_manager_browsertest.cc - Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_browsertest.cc

Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc ('k') | chrome/browser/ui/views/extensions/extension_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager_browsertest.cc

===================================================================

--- chrome/browser/task_manager/task_manager_browsertest.cc (revision 66634)

+++ chrome/browser/task_manager/task_manager_browsertest.cc (working copy)

@@ -12,6 +12,7 @@

#include "chrome/browser/extensions/crashed_extension_infobar.h"

#include "chrome/browser/extensions/extension_browsertest.h"

#include "chrome/browser/notifications/desktop_notification_service.h"

+#include "chrome/browser/notifications/notification.h"

#include "chrome/browser/notifications/notification_test_util.h"

#include "chrome/browser/notifications/notification_ui_manager.h"

#include "chrome/browser/profile.h"

@@ -200,9 +201,9 @@

WaitForResourceChange(3);

notifications->Add(n2, browser()->profile());

WaitForResourceChange(4);

- notifications->Cancel(n1);

+ notifications->CancelById(n1.notification_id());

WaitForResourceChange(3);

- notifications->Cancel(n2);

+ notifications->CancelById(n2.notification_id());

WaitForResourceChange(2);

}