chrome/browser/chromeos/notifications/desktop_notifications_unittest.h - Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/notifications/desktop_notifications_unittest.h

Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/notifications/balloon_view.cc ('k') | chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/notifications/desktop_notifications_unittest.h

===================================================================

--- chrome/browser/chromeos/notifications/desktop_notifications_unittest.h (revision 66634)

+++ chrome/browser/chromeos/notifications/desktop_notifications_unittest.h (working copy)

@@ -17,7 +17,6 @@

#include "chrome/browser/notifications/balloon.h"

#include "chrome/browser/notifications/desktop_notification_service.h"

#include "chrome/browser/notifications/notification.h"

-#include "chrome/browser/notifications/notification_object_proxy.h"

#include "chrome/browser/notifications/notification_test_util.h"

#include "chrome/browser/notifications/notification_ui_manager.h"

#include "chrome/browser/notifications/notifications_prefs_cache.h"

@@ -28,7 +27,7 @@

namespace chromeos {

class DesktopNotificationsTest;

-typedef LoggingNotificationProxyBase<DesktopNotificationsTest>

+typedef LoggingNotificationDelegate<DesktopNotificationsTest>

LoggingNotificationProxy;

// Test version of the balloon collection which counts the number

@@ -40,7 +39,6 @@

// BalloonCollectionImpl overrides

virtual void Add(const Notification& notification,

Profile* profile);

- virtual bool Remove(const Notification& notification);

virtual Balloon* MakeBalloon(const Notification& notification,

Profile* profile);

virtual void OnBalloonClosed(Balloon* source);

@@ -54,7 +52,6 @@

private:

std::set<Balloon*> balloons_;

- scoped_refptr<LoggingNotificationProxy> log_proxy_;

};

class DesktopNotificationsTest : public testing::Test {