chrome/browser/chromeos/notifications/balloon_view.cc - Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/notifications/balloon_view.cc

Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/notifications/balloon_collection_impl.cc ('k') | chrome/browser/chromeos/notifications/desktop_notifications_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/notifications/balloon_view.cc

===================================================================

--- chrome/browser/chromeos/notifications/balloon_view.cc (revision 66634)

+++ chrome/browser/chromeos/notifications/balloon_view.cc (working copy)

@@ -15,6 +15,7 @@

#include "chrome/browser/chromeos/notifications/notification_panel.h"

#include "chrome/browser/notifications/balloon.h"

#include "chrome/browser/notifications/desktop_notification_service.h"

+#include "chrome/browser/notifications/notification.h"

#include "chrome/browser/profile.h"

#include "chrome/browser/renderer_host/render_view_host.h"

#include "chrome/browser/renderer_host/render_widget_host_view.h"

@@ -300,7 +301,8 @@

// BalloonViewImpl public.

bool BalloonViewImpl::IsFor(const Notification& notification) const {

- return balloon_->notification().IsSame(notification);

+ return balloon_->notification().notification_id() ==

+ notification.notification_id();

}

void BalloonViewImpl::Activated() {