When an extension is uninstalled, close all desktop notifications from that e...

chrome/browser/chromeos/notifications/notification_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/x11_util.h"
 #include "base/message_loop.h"
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
 #include "base/string16.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/notifications/balloon_collection_impl.h"
 #include "chrome/browser/chromeos/notifications/balloon_view.h"
 #include "chrome/browser/chromeos/notifications/notification_panel.h"
 #include "chrome/browser/chromeos/notifications/system_notification_factory.h"
-#include "chrome/browser/notifications/notification_delegate.h"
+#include "chrome/browser/notifications/notification_test_util.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/test/in_process_browser_test.h"
 #include "chrome/test/ui_test_utils.h"
 
 namespace {
 
-class MockNotificationDelegate : public NotificationDelegate {
- public:
-  explicit MockNotificationDelegate(const std::string& id) : id_(id) {}
-
-  virtual void Display() {}
-  virtual void Error() {}
-  virtual void Close(bool by_user) {}
-  virtual void Click() {}
-  virtual std::string id() const { return id_; }
-
- private:
-  std::string id_;
-
-  DISALLOW_COPY_AND_ASSIGN(MockNotificationDelegate);
-};
-
 // The name of ChromeOS's window manager.
 const char* kChromeOsWindowManagerName = "chromeos-wm";
 
 }  // namespace
 
 namespace chromeos {
 
 class NotificationTest : public InProcessBrowserTest,
                          public NotificationObserver {
  public:
@@ skipping 102 matching lines @@
   EXPECT_EQ(1, tester->GetNotificationCount());
   EXPECT_EQ(0, tester->GetStickyNotificationCount());
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
 
   collection->Add(NewMockNotification("2"), browser()->profile());
 
   EXPECT_EQ(2, tester->GetNewNotificationCount());
   EXPECT_EQ(2, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
 
-  collection->Remove(NewMockNotification("1"));
+  collection->RemoveById("1");
   ui_test_utils::RunAllPendingInMessageLoop();
 
   EXPECT_EQ(1, tester->GetNewNotificationCount());
   EXPECT_EQ(1, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
 
-  collection->Remove(NewMockNotification("2"));
+  collection->RemoveById("2");
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(0, tester->GetNewNotificationCount());
   EXPECT_EQ(0, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::CLOSED, tester->state());
 
   // CLOSE is asynchronous. Run the all pending tasks to finish closing
   // task.
   ui_test_utils::RunAllPendingInMessageLoop();
 }
 
 // [CLOSED] -add->[STICKY_AND_NEW] -mouse-> [KEEP_SIZE] -remove/add->
 // [KEEP_SIZE] -remove-> [CLOSED] -add-> [STICKY_AND_NEW] -remove-> [CLOSED]
 IN_PROC_BROWSER_TEST_F(NotificationTest, TestKeepSizeState) {
   BalloonCollectionImpl* collection = GetBalloonCollectionImpl();
   NotificationPanel* panel = GetNotificationPanel();
   NotificationPanelTester* tester = panel->GetTester();
 
   EXPECT_EQ(NotificationPanel::CLOSED, tester->state());
 
   // Using system notification as regular notification.
   collection->Add(NewMockNotification("1"), browser()->profile());
   collection->Add(NewMockNotification("2"), browser()->profile());
 
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
 
   panel->OnMouseMotion(gfx::Point(10, 10));
   EXPECT_EQ(NotificationPanel::KEEP_SIZE, tester->state());
 
-  collection->Remove(NewMockNotification("1"));
+  collection->RemoveById("1");
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(1, tester->GetNewNotificationCount());
   EXPECT_EQ(1, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::KEEP_SIZE, tester->state());
 
   collection->Add(NewMockNotification("1"), browser()->profile());
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(2, tester->GetNewNotificationCount());
   EXPECT_EQ(2, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::KEEP_SIZE, tester->state());
 
-  collection->Remove(NewMockNotification("1"));
+  collection->RemoveById("1");
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(1, tester->GetNewNotificationCount());
   EXPECT_EQ(1, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::KEEP_SIZE, tester->state());
 
-  collection->Remove(NewMockNotification("2"));
+  collection->RemoveById("2");
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(0, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::CLOSED, tester->state());
 
   collection->Add(NewMockNotification("3"), browser()->profile());
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
-  collection->Remove(NewMockNotification("3"));
+  collection->RemoveById("3");
 
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(0, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::CLOSED, tester->state());
 }
 
 IN_PROC_BROWSER_TEST_F(NotificationTest, TestSystemNotification) {
   BalloonCollectionImpl* collection = GetBalloonCollectionImpl();
   NotificationPanel* panel = GetNotificationPanel();
   scoped_refptr<MockNotificationDelegate> delegate(
@@ skipping 13 matching lines @@
   EXPECT_EQ(1, tester->GetStickyNotificationCount());
 
   Notification update_and_show = SystemNotificationFactory::Create(
       GURL(), ASCIIToUTF16("Title"), ASCIIToUTF16("updated and shown"),
       delegate.get());
   collection->UpdateAndShowNotification(update_and_show);
 
   EXPECT_EQ(1, tester->GetStickyNotificationCount());
 
   // Dismiss the notification.
-  // TODO(oshima): Consider updating API to Remove(NotificationDelegate)
-  // or Remove(std::string id);
-  collection->Remove(Notification(GURL(), GURL(), string16(), string16(),
-                                  delegate.get()));
+  collection->RemoveById(delegate->id());
   ui_test_utils::RunAllPendingInMessageLoop();
 
   EXPECT_EQ(0, tester->GetStickyNotificationCount());
   EXPECT_EQ(0, tester->GetNewNotificationCount());
   // TODO(oshima): check content, etc..
 }
 
 // [CLOSED] -add,add->[STICKY_AND_NEW] -stale-> [MINIMIZED] -remove->
 // [MINIMIZED] -remove-> [CLOSED]
 IN_PROC_BROWSER_TEST_F(NotificationTest, TestStateTransition1) {
   BalloonCollectionImpl* collection = GetBalloonCollectionImpl();
   NotificationPanel* panel = GetNotificationPanel();
   NotificationPanelTester* tester = panel->GetTester();
 
   tester->SetStaleTimeout(0);
   EXPECT_EQ(NotificationPanel::CLOSED, tester->state());
 
   collection->Add(NewMockNotification("1"), browser()->profile());
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
 
   collection->Add(NewMockNotification("2"), browser()->profile());
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
 
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(NotificationPanel::MINIMIZED, tester->state());
 
-  collection->Remove(NewMockNotification("2"));
+  collection->RemoveById("2");
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(NotificationPanel::MINIMIZED, tester->state());
 
-  collection->Remove(NewMockNotification("1"));
+  collection->RemoveById("1");
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(0, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::CLOSED, tester->state());
 
   ui_test_utils::RunAllPendingInMessageLoop();
 }
 
 // [CLOSED] -add->[STICKY_AND_NEW] -stale-> [MINIMIZED] -add->
 // [STICKY_AND_NEW] -stale-> [MINIMIZED] -add sys-> [STICKY_NEW]
 // -stale-> [STICKY_NEW] -remove-> [STICKY_NEW] -remove sys->
@@ skipping 45 matching lines @@
   collection->AddSystemNotification(
       NewMockNotification("3"), browser()->profile(), true, false);
   EXPECT_EQ(3, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
   WaitForPanelState(tester, PanelController::EXPANDED);
 
   // Running all events nor removing non sticky should not change the state.
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
 
-  collection->Remove(NewMockNotification("1"));
+  collection->RemoveById("1");
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(NotificationPanel::STICKY_AND_NEW, tester->state());
 
   // Removing the system notification should minimize the panel.
-  collection->Remove(NewMockNotification("3"));
+  collection->RemoveById("3");
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(1, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::MINIMIZED, tester->state());
   WaitForPanelState(tester, PanelController::MINIMIZED);
 
   // Removing the last notification. Should close the panel.
-
-  collection->Remove(NewMockNotification("2"));
+  collection->RemoveById("2");
   ui_test_utils::RunAllPendingInMessageLoop();
   EXPECT_EQ(0, tester->GetNotificationCount());
   EXPECT_EQ(NotificationPanel::CLOSED, tester->state());
 
   ui_test_utils::RunAllPendingInMessageLoop();
 }
 
 IN_PROC_BROWSER_TEST_F(NotificationTest, TestCleanupOnExit) {
   NotificationRegistrar registrar;
   registrar.Add(this,
@@ skipping 224 matching lines @@
   EXPECT_TRUE(collection->AddDOMUIMessageCallback(
       NewMockNotification("1"),
       "test",
       NewCallback(
           static_cast<NotificationTest*>(this),
           &NotificationTest::HandleDOMUIMessage)));
   MessageLoop::current()->Run();
 }
 
 }  // namespace chromeos