Add chrome.usbPrivate API for use by USB device WEBUI.

Add chrome.usbPrivate API for use by USB device WEBUI.

This private API exposes more information about connected USB devices
than the public chrome.usb API. It is designed for use by WEBUI
components that wish to display information about connected to devices
to the user such as the dialog box shown by the proposed
chrome.usb.getUserSelectedDevices API.

BUG=346953
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289530

[Reilly Grant (use Gerrit), 2014-08-11 22:00:15]

Adding asvitkine@chromium.org to review changes to
extension_function_histogram_value.h.

[Alexei Svitkine (slow), 2014-08-11 22:01:27]

https://codereview.chromium.org/463493006/diff/20001/extensions/browser/exten...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/463493006/diff/20001/extensions/browser/exten...
extensions/browser/extension_function_histogram_value.h:925:
USBPRIVATE_GETDEVICES,
Please also update histograms.xml.

[Ken Rockot(use gerrit already), 2014-08-13 19:19:00]

Nice. lgtm with a few small comments

https://codereview.chromium.org/463493006/diff/40001/components/usb_service/u...
File components/usb_service/usb_device_handle_impl.cc (right):

https://codereview.chromium.org/463493006/diff/40001/components/usb_service/u...
components/usb_service/usb_device_handle_impl.cc:380: uint16 languages[256];
Only need 128 here and below.

https://codereview.chromium.org/463493006/diff/40001/components/usb_service/u...
components/usb_service/usb_device_handle_impl.cc:394: } else if ((languages[0] &
0xff) != size) {
Please add a comment documenting the contents of the returned text buffer.

[Alexei Svitkine (slow), 2014-08-13 19:32:23]

histograms lgtm

[Reilly Grant (use Gerrit), 2014-08-13 21:20:43]

Rebased and addressed rockot's feedback. Added dgozman to review the update to
android_usb_browsertest.cc.

https://codereview.chromium.org/463493006/diff/40001/components/usb_service/u...
File components/usb_service/usb_device_handle_impl.cc (right):

https://codereview.chromium.org/463493006/diff/40001/components/usb_service/u...
components/usb_service/usb_device_handle_impl.cc:380: uint16 languages[256];
On 2014/08/13 19:19:00, Ken Rockot wrote:
> Only need 128 here and below.

Done.

https://codereview.chromium.org/463493006/diff/40001/components/usb_service/u...
components/usb_service/usb_device_handle_impl.cc:394: } else if ((languages[0] &
0xff) != size) {
On 2014/08/13 19:19:00, Ken Rockot wrote:
> Please add a comment documenting the contents of the returned text buffer.

Done.

[dgozman, 2014-08-14 02:57:58]

chrome/browser/devtools lgtm

https://codereview.chromium.org/463493006/diff/60001/chrome/browser/devtools/...
File chrome/browser/devtools/device/usb/android_usb_browsertest.cc (right):

https://codereview.chromium.org/463493006/diff/60001/chrome/browser/devtools/...
chrome/browser/devtools/device/usb/android_usb_browsertest.cc:46: const char
kDeviceManufacturer[] = "Google Inc.";
I'd prefer "Test manufacturer".

[Reilly Grant (use Gerrit), 2014-08-14 03:55:54]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-08-14 04:01:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reillyg@chromium.org/463493006/80001

[commit-bot: I haz the power, 2014-08-14 10:02:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-14 12:09:58]

Committed patchset #5 (80001) as 289530