Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11895)

Unified Diff: components/cronet.gypi

Issue 463493005: Split cronet.jar into cronet.jar and cronet_api.jar, preserve full libcronet.so (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Better comment. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/proguard.cfg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet.gypi
diff --git a/components/cronet.gypi b/components/cronet.gypi
index c0dfb33414eb7cbe0eb8caf8b47a22b86f5c7629..502b45b015c7a1f3eebeadbca7705a2c632a550b 100644
--- a/components/cronet.gypi
+++ b/components/cronet.gypi
@@ -152,17 +152,53 @@
],
],
},
- {
+ { # cronet_stub.jar defines HttpUrlRequest interface and provides its
+ # its implementation using HttpUrlConnection (not the Chromium stack).
+ 'target_name': 'cronet_stub',
+ 'type': 'none',
+ 'dependencies': [
+ 'cronet_url_request_context_config_list',
+ 'cronet_version',
+ ],
+ 'variables': {
+ 'java_in_dir': 'cronet/android/java',
+ 'javac_includes': [
+ '**/ChunkedWritableByteChannel.java',
+ '**/HttpUrlConnection*.java',
+ '**/HttpUrlRequest*.java',
+ '**/ResponseTooLargeException.java',
+ '**/UserAgent.java',
+ # TODO(mef): Consider moving this into HttpUrlRequestConfig.
+ '**/UrlRequestContextConfig.java',
+ '**/Version.java',
+ ],
+ },
+ 'includes': [ '../build/java.gypi' ],
+ },
+ { # cronet.jar implements HttpUrlRequest interface using Chromium stack
+ # in native libcronet.so library.
'target_name': 'cronet',
'type': 'none',
'dependencies': [
'../base/base.gyp:base',
- 'libcronet',
+ 'cronet_stub',
'cronet_url_request_error_list',
'cronet_url_request_priority_list',
+ 'libcronet',
],
'variables': {
'java_in_dir': 'cronet/android/java',
+ 'javac_includes': [
+ '**/ChromiumUrlRequest.java',
+ '**/ChromiumUrlRequestFactory.java',
+ '**/LibraryLoader.java',
+ # TODO(mef): Merge UrlRequest*.java into ChromiumUrlRequest*.java
+ '**/UrlRequest.java',
+ '**/UrlRequestContext.java',
+ '**/UrlRequestError.java',
+ '**/UrlRequestPriority.java',
+ '**/UsedByReflection.java',
+ ],
},
'includes': [ '../build/java.gypi' ],
},
@@ -172,12 +208,15 @@
'dependencies': [
'libcronet',
'cronet',
+ 'cronet_stub',
],
'variables': {
'native_lib': 'libcronet.>(android_product_extension)',
'java_lib': 'cronet.jar',
+ 'java_stub_lib': 'cronet_stub.jar',
'java_src_lib': 'cronet-src.jar',
'java_sample_src_lib': 'cronet-sample-src.jar',
+ 'lib_java_dir': '<(PRODUCT_DIR)/lib.java',
'package_dir': '<(PRODUCT_DIR)/cronet',
'intermediate_dir': '<(SHARED_INTERMEDIATE_DIR)/cronet',
'jar_extract_dir': '<(intermediate_dir)/cronet_jar_extract',
@@ -203,10 +242,10 @@
{
'action_name': 'extracting from jars',
'inputs': [
- '<(PRODUCT_DIR)/lib.java/<(java_lib)',
- '<(PRODUCT_DIR)/lib.java/base_java.jar',
- '<(PRODUCT_DIR)/lib.java/net_java.jar',
- '<(PRODUCT_DIR)/lib.java/url_java.jar',
+ '<(lib_java_dir)/<(java_lib)',
+ '<(lib_java_dir)/base_java.jar',
+ '<(lib_java_dir)/net_java.jar',
+ '<(lib_java_dir)/url_java.jar',
],
'outputs': ['<(jar_extract_stamp)', '<(jar_extract_dir)'],
'action': [
@@ -279,6 +318,13 @@
'../AUTHORS',
'../chrome/VERSION',
'cronet/android/proguard.cfg',
+ '<(lib_java_dir)/<(java_stub_lib)'
+ ],
+ },
+ {
+ 'destination': '<(package_dir)/symbols/<(android_app_abi)',
+ 'files': [
+ '<(SHARED_LIB_DIR)/<(native_lib)',
],
},
],
« no previous file with comments | « no previous file | components/cronet/android/proguard.cfg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698