Split cronet.jar into cronet.jar and cronet_api.jar, preserve full libcronet.so

Split cronet.jar into cronet.jar and cronet_api.jar.
Preserve full libcronet.so for crash log symbolication.
Upstream proguard.cfg changes.

BUG=396781
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289136

[mef, 2014-08-11 21:14:13]

Hi guys, please take a look. This CL is needed to keep full symbols of
libcronet.so and upstream clm's changes for cronet/cronet_api split.

[Charles, 2014-08-11 21:20:24]

lgtm

[commit-bot: I haz the power, 2014-08-11 21:22:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mef@chromium.org/463493005/1

[commit-bot: I haz the power, 2014-08-11 21:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 21:22:42]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[mmenke, 2014-08-12 14:48:16]

https://codereview.chromium.org/463493005/diff/1/components/cronet.gypi
File components/cronet.gypi (right):

https://codereview.chromium.org/463493005/diff/1/components/cronet.gypi#newco...
components/cronet.gypi:166: '**/HttpUrlConnection*.java',
Why is this part of "cronet_api", but not the Chromium equivalents?  Perhaps a
rename (And some comments?) for these targets is in order?

https://codereview.chromium.org/463493005/diff/1/components/cronet/android/pr...
File components/cronet/android/proguard.cfg (right):

https://codereview.chromium.org/463493005/diff/1/components/cronet/android/pr...
components/cronet/android/proguard.cfg:27: }
Is there any documentation for this stuff?

[mef, 2014-08-12 16:36:11]

Thanks Matt, PTAL.

https://codereview.chromium.org/463493005/diff/1/components/cronet.gypi
File components/cronet.gypi (right):

https://codereview.chromium.org/463493005/diff/1/components/cronet.gypi#newco...
components/cronet.gypi:166: '**/HttpUrlConnection*.java',
On 2014/08/12 14:48:15, mmenke wrote:
> Why is this part of "cronet_api", but not the Chromium equivalents?  Perhaps a
> rename (And some comments?) for these targets is in order?

Renamed cronet_api into cronet_stub to reflect the fact that it also provides
basic implementation.

https://codereview.chromium.org/463493005/diff/1/components/cronet/android/pr...
File components/cronet/android/proguard.cfg (right):

https://codereview.chromium.org/463493005/diff/1/components/cronet/android/pr...
components/cronet/android/proguard.cfg:27: }
On 2014/08/12 14:48:15, mmenke wrote:
> Is there any documentation for this stuff?
http://developer.android.com/tools/help/proguard.html (I'm not familiar with it
though).

[mmenke, 2014-08-12 16:40:14]

LGTM

https://codereview.chromium.org/463493005/diff/20001/components/cronet.gypi
File components/cronet.gypi (right):

https://codereview.chromium.org/463493005/diff/20001/components/cronet.gypi#n...
components/cronet.gypi:156: # its implementation using HttpUrlConnection.
nit:  Don't use tabs.

https://codereview.chromium.org/463493005/diff/20001/components/cronet.gypi#n...
components/cronet.gypi:156: # its implementation using HttpUrlConnection.
Maybe add "(Not the Chromium network stack)"

https://codereview.chromium.org/463493005/diff/20001/components/cronet.gypi#n...
components/cronet.gypi:179: # in native libcronet.so library.
nit:  Don't use tabs.

[mmenke, 2014-08-12 16:40:15]

LGTM

https://codereview.chromium.org/463493005/diff/20001/components/cronet.gypi
File components/cronet.gypi (right):

https://codereview.chromium.org/463493005/diff/20001/components/cronet.gypi#n...
components/cronet.gypi:156: # its implementation using HttpUrlConnection.
nit:  Don't use tabs.

[mef, 2014-08-12 17:30:35]

Thanks!

https://codereview.chromium.org/463493005/diff/20001/components/cronet.gypi
File components/cronet.gypi (right):

https://codereview.chromium.org/463493005/diff/20001/components/cronet.gypi#n...
components/cronet.gypi:156: # its implementation using HttpUrlConnection.
On 2014/08/12 16:40:15, mmenke wrote:
> nit:  Don't use tabs.

Oops. I swear it is vi's fault. :) Done.

https://codereview.chromium.org/463493005/diff/20001/components/cronet.gypi#n...
components/cronet.gypi:179: # in native libcronet.so library.
On 2014/08/12 16:40:14, mmenke wrote:
> nit:  Don't use tabs.

Done.

[mef, 2014-08-12 17:30:53]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-08-12 17:31:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mef@chromium.org/463493005/60001

[commit-bot: I haz the power, 2014-08-12 21:48:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-13 00:39:37]

Change committed as 289136