Issue 463493004: In PageAnimator iterate through collected documents instead of frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 463493004: In PageAnimator iterate through collected documents instead of frames (Closed)

Created:
6 years, 4 months ago by weiliangc

Modified:
6 years, 4 months ago

Reviewers:
abarth-chromium

CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, danakj, dstockwell, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh, Ian Vollick

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

In PageAnimator iterate through collected documents instead of frames In PageAnimator, it's possible frame tree has been mutated by Javascript. To avoid this, we iterator through documents collection instead, and check whether they are still present in their frames. This was part of CL 214953004, which got reverted in 335103004 when it caused crbug.com/383946. So I am adding back the reverted CL in parts. This part should be only related to crbug.com/359028. BUG=359028 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179992