Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: pkg/analysis_services/lib/src/completion/local_computer.dart

Issue 463493003: rename CompletionSuggestionKind.VARIABLE to LOCAL_VARIABLE to match spec (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_services/lib/src/completion/local_computer.dart
diff --git a/pkg/analysis_services/lib/src/completion/local_computer.dart b/pkg/analysis_services/lib/src/completion/local_computer.dart
index 8a6799d24099e217a17d11ebd75ac4f19395f57d..a17b066a618f174c92c72efad4d2a998fbf67b36 100644
--- a/pkg/analysis_services/lib/src/completion/local_computer.dart
+++ b/pkg/analysis_services/lib/src/completion/local_computer.dart
@@ -87,7 +87,9 @@ class _LocalVisitor extends GeneralizingAstVisitor<dynamic> {
} else if (stmt is VariableDeclarationStatement) {
stmt.variables.variables.forEach((VariableDeclaration varDecl) {
if (varDecl.end < offset) {
- addSuggestion(varDecl.name, CompletionSuggestionKind.VARIABLE);
+ addSuggestion(
+ varDecl.name,
+ CompletionSuggestionKind.LOCAL_VARIABLE);
}
});
}
@@ -143,12 +145,12 @@ class _LocalVisitor extends GeneralizingAstVisitor<dynamic> {
}
visitForEachStatement(ForEachStatement node) {
- addSuggestion(node.identifier, CompletionSuggestionKind.VARIABLE);
+ addSuggestion(node.identifier, CompletionSuggestionKind.LOCAL_VARIABLE);
visitNode(node);
}
visitForStatement(ForStatement node) {
- addSuggestions(node.variables, CompletionSuggestionKind.VARIABLE);
+ addSuggestions(node.variables, CompletionSuggestionKind.LOCAL_VARIABLE);
visitNode(node);
}

Powered by Google App Engine
This is Rietveld 408576698