rename CompletionSuggestionKind.VARIABLE to LOCAL_VARIABLE to match spec

pkg/analysis_services/lib/completion/completion_suggestion.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.suggestion;
 
 import 'package:analysis_services/constants.dart';
 import 'package:analysis_services/json.dart';
 import 'package:analyzer/src/generated/element.dart';
 
@@ skipping 125 matching lines @@
   static const CompletionSuggestionKind FUNCTION =
       const CompletionSuggestionKind('FUNCTION');
   static const CompletionSuggestionKind FUNCTION_TYPE_ALIAS =
       const CompletionSuggestionKind('FUNCTION_TYPE_ALIAS');
   static const CompletionSuggestionKind GETTER =
       const CompletionSuggestionKind('GETTER');
   static const CompletionSuggestionKind IMPORT =
       const CompletionSuggestionKind('IMPORT');
   static const CompletionSuggestionKind LIBRARY_PREFIX =
       const CompletionSuggestionKind('LIBRARY_PREFIX');
+  static const CompletionSuggestionKind LOCAL_VARIABLE =
+      const CompletionSuggestionKind('LOCAL_VARIABLE');
   static const CompletionSuggestionKind METHOD =
       const CompletionSuggestionKind('METHOD');
   static const CompletionSuggestionKind METHOD_NAME =
       const CompletionSuggestionKind('METHOD_NAME');
   static const CompletionSuggestionKind NAMED_ARGUMENT =
       const CompletionSuggestionKind('NAMED_ARGUMENT');
   static const CompletionSuggestionKind OPTIONAL_ARGUMENT =
       const CompletionSuggestionKind('OPTIONAL_ARGUMENT');
   static const CompletionSuggestionKind PARAMETER =
       const CompletionSuggestionKind('PARAMETER');
   static const CompletionSuggestionKind SETTER =
       const CompletionSuggestionKind('SETTER');
   static const CompletionSuggestionKind TOP_LEVEL_VARIABLE =
       const CompletionSuggestionKind('TOP_LEVEL_VARIABLE');
   static const CompletionSuggestionKind TYPE_PARAMETER =
       const CompletionSuggestionKind('TYPE_PARAMETER');
-  // TODO (danrubel) consider renaming VARIABLE --> LOCAL_VARIABLE
-  //                 to match ElementKind.LOCAL_VARIABLE
-  static const CompletionSuggestionKind VARIABLE =
-      const CompletionSuggestionKind('VARIABLE');
 
   final String name;
 
   const CompletionSuggestionKind(this.name);
 
   @override
   String toString() => name;
 
   static CompletionSuggestionKind fromElementKind(ElementKind kind) {
     //    ElementKind.ANGULAR_FORMATTER,
@@ skipping 13 matching lines @@
     //    ElementKind.EXPORT,
     //    ElementKind.EXTERNAL_HTML_SCRIPT,
     if (kind == ElementKind.FIELD) return FIELD;
     if (kind == ElementKind.FUNCTION) return FUNCTION;
     if (kind == ElementKind.FUNCTION_TYPE_ALIAS) return FUNCTION_TYPE_ALIAS;
     if (kind == ElementKind.GETTER) return GETTER;
     //    ElementKind.HTML,
     if (kind == ElementKind.IMPORT) return IMPORT;
     //    ElementKind.LABEL,
     //    ElementKind.LIBRARY,
-    if (kind == ElementKind.LOCAL_VARIABLE) return VARIABLE;
+    if (kind == ElementKind.LOCAL_VARIABLE) return LOCAL_VARIABLE;
     if (kind == ElementKind.METHOD) return METHOD;
     //    ElementKind.NAME,
     if (kind == ElementKind.PARAMETER) return PARAMETER;
     //    ElementKind.POLYMER_ATTRIBUTE,
     //    ElementKind.POLYMER_TAG_DART,
     //    ElementKind.POLYMER_TAG_HTML,
     //    ElementKind.PREFIX,
     if (kind == ElementKind.SETTER) return SETTER;
     if (kind == ElementKind.TOP_LEVEL_VARIABLE) return TOP_LEVEL_VARIABLE;
     //    ElementKind.TYPE_PARAMETER,
     //    ElementKind.UNIVERSE
     throw new ArgumentError('Unknown CompletionSuggestionKind for: $kind');
   }
 
   static CompletionSuggestionKind valueOf(String name) {
     if (ARGUMENT_LIST.name == name) return ARGUMENT_LIST;
     if (CLASS.name == name) return CLASS;
     if (CLASS_ALIAS.name == name) return CLASS_ALIAS;
     if (CONSTRUCTOR.name == name) return CONSTRUCTOR;
     if (FIELD.name == name) return FIELD;
     if (FUNCTION.name == name) return FUNCTION;
     if (FUNCTION_TYPE_ALIAS.name == name) return FUNCTION_TYPE_ALIAS;
     if (GETTER.name == name) return GETTER;
     if (IMPORT.name == name) return IMPORT;
     if (LIBRARY_PREFIX.name == name) return LIBRARY_PREFIX;
+    if (LOCAL_VARIABLE.name == name) return LOCAL_VARIABLE;
     if (METHOD.name == name) return METHOD;
     if (METHOD_NAME.name == name) return METHOD_NAME;
     if (NAMED_ARGUMENT.name == name) return NAMED_ARGUMENT;
     if (OPTIONAL_ARGUMENT.name == name) return OPTIONAL_ARGUMENT;
     if (PARAMETER.name == name) return PARAMETER;
     if (SETTER.name == name) return SETTER;
     if (TOP_LEVEL_VARIABLE.name == name) return TOP_LEVEL_VARIABLE;
     if (TYPE_PARAMETER.name == name) return TYPE_PARAMETER;
-    if (VARIABLE.name == name) return VARIABLE;
     throw new ArgumentError('Unknown CompletionSuggestionKind: $name');
   }
 }