SkCanvas::drawPatch param SkPoint[12]

include/core/SkCanvas.h

Index: include/core/SkCanvas.h
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
index 791511e768088720ad5dd9192bc5a64fd21dd1a1..ec25db30b68d9069616b1e147fee91451b6d2b7f 100644
--- a/include/core/SkCanvas.h
+++ b/include/core/SkCanvas.h
@@ -1022,14 +1022,21 @@ public:
                               const uint16_t indices[], int indexCount,
                               const SkPaint& paint);
     
-    /** 
-     
+    /**
      Draw a SkPatch
      
-     @param patch specifies the 4 bounding cubic bezier curves of a patch.
+     @param cubic specifies the 4 bounding cubic bezier curves of a patch with clockwise order
+                    starting at the top left corner.
+     @param colors specifies the colors for the corners which will be bilerp across the patch,
+                    their order is clockwise starting at the top left corner.
+     @param texCoords specifies the texture coordinates that will be bilerp across the patch, 
+                    their order is the same as the colors.
+     @param xmode specifies how are the colors and the textures combined if both of them are 
+                    present.
      @param paint Specifies the shader/texture if present.
      */
-    virtual void drawPatch(const SkPatch& patch, const SkPaint& paint);
+    virtual void drawPatch(const SkPoint cubics[12], const SkColor colors[4],

[reed1, 2014/08/11 13:50:23]

I like.

nit: lets make this version non-virtual, and add a protected virtual
onDrawPatch, so we can inject some shared debugging/checks in the non-virtual
version.

[dandov, 2014/08/11 14:45:07]

I did this in 2 patch sets in the first I just added the virtual call and
adjusted all the 
other ones and in the second one I understood the shared/debugging checks and 
put them in drawPatch and removed them from the derived onDrawPatch.

+                           const SkPoint texCoords[4], SkXfermode* xmode, const SkPaint& paint);
 
     /** Send a blob of data to the canvas.
         For canvases that draw, this call is effectively a no-op, as the data