Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 463433002: Oilpan: fix build after r179934. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, tzik, sof, eae+blinkwatch, nhiroki, falken, blink-reviews-dom_chromium.org, dglazkov+blink, kinuko+serviceworker, gavinp+loader_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, Nate Chapin, alecflett+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r179934. TBR=haraken,oilpan-reviews BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -49 lines) Patch
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContextClient.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/csp/CSPDirectiveList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerObjectProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerObjectProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerReportingProxy.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 4 chunks +15 lines, -18 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-11 11:03:00 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-11 11:12:29 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-11 11:14:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/463433002/1
6 years, 4 months ago (2014-08-11 11:15:30 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 11:16:16 UTC) #5
Message was sent while issue was closed. 
Change committed as 179935

Powered by Google App Engine
This is Rietveld 408576698