Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: scripts/slave/recipes/gpu.py

Issue 46343002: Run run_crash_handler and process_dumps on Windows GPU bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Retrying failed upload. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/gpu.expected/win_debug.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/gpu.py
diff --git a/scripts/slave/recipes/gpu.py b/scripts/slave/recipes/gpu.py
index ec2b49243ed5d3cf6090720b38becf33e6dae324..f57bca6d38684789b51b60bd5705f040a1534f3d 100644
--- a/scripts/slave/recipes/gpu.py
+++ b/scripts/slave/recipes/gpu.py
@@ -96,6 +96,17 @@ def GenSteps(api):
# and the setting of these properties should happen in this recipe
# instead.
+ # On Windows, start the crash service.
+ if api.platform.is_win:
+ yield api.python(
+ 'start_crash_service',
+ api.path.build('scripts', 'slave', 'chromium',
+ 'run_crash_handler.py'),
+ ['--build-dir',
+ api.path.checkout('out'),
+ '--target',
+ 'Release' if is_release_build else 'Debug'])
+
# Note: --no-xvfb is the default.
for test in SIMPLE_TESTS_TO_RUN:
yield api.chromium.runtests(test, spawn_dbus=True)
@@ -168,6 +179,16 @@ def GenSteps(api):
# TODO(kbr): after the conversion to recipes, add all GPU related
# steps from the main waterfall, like gpu_unittests.
+ # On Windows, process any crash dumps that may have occurred.
+ if api.platform.is_win:
+ yield api.python(
+ 'process_dumps',
+ api.path.build('scripts', 'slave', 'process_dumps.py'),
+ ['--build-dir',
+ api.path.checkout('out'),
+ '--target',
+ 'Release' if is_release_build else 'Debug'])
+
def GenTests(api):
for build_config in ['Release', 'Debug']:
for plat in ['win', 'mac', 'linux']:
« no previous file with comments | « no previous file | scripts/slave/recipes/gpu.expected/win_debug.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698