Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 463423003: ServiceWorker: Rename Client interface to ServiceWorkerClient (Closed)

Created:
6 years, 4 months ago by jsbell
Modified:
6 years, 4 months ago
Reviewers:
falken, haraken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, arv+blink, tzik, serviceworker-reviews, blink-reviews-bindings_chromium.org, nhiroki, abarth-chromium, falken, kinuko+serviceworker, horo+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Rename Client interface to ServiceWorkerClient The interface was given a less generic name in a recent spec update: https://github.com/slightlyoff/ServiceWorker/issues/350 BUG=403536 R=falken@chromium.org,haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180291

Patch Set 1 #

Patch Set 2 : Fix GN build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -149 lines) Patch
M LayoutTests/http/tests/serviceworker/postmessage-msgport-to-client.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-to-client.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js View 1 chunk +1 line, -1 line 0 comments Download
D Source/bindings/modules/v8/custom/V8ClientCustom.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
A + Source/bindings/modules/v8/custom/V8ServiceWorkerClientCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/modules/v8/custom/custom.gni View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/custom/custom.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/modules.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
D Source/modules/serviceworkers/Client.h View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/modules/serviceworkers/Client.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D Source/modules/serviceworkers/Client.idl View 1 chunk +0 lines, -17 lines 0 comments Download
A + Source/modules/serviceworkers/ServiceWorkerClient.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + Source/modules/serviceworkers/ServiceWorkerClient.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
A + Source/modules/serviceworkers/ServiceWorkerClient.idl View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jsbell
Trivial - noticed while doing a fuzzer update. falken@, haraken@ - please take a look?
6 years, 4 months ago (2014-08-13 23:44:32 UTC) #1
haraken
LGTM if falken is happy about the rename.
6 years, 4 months ago (2014-08-14 00:45:05 UTC) #2
falken
rename LGTM
6 years, 4 months ago (2014-08-14 04:15:52 UTC) #3
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-08-14 04:15:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/463423003/1
6 years, 4 months ago (2014-08-14 04:16:34 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-14 06:55:15 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 07:33:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/7457)
6 years, 4 months ago (2014-08-14 07:33:08 UTC) #8
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-08-14 10:57:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/463423003/1
6 years, 4 months ago (2014-08-14 10:59:11 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-14 12:35:33 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 14:20:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/7503)
6 years, 4 months ago (2014-08-14 14:20:02 UTC) #13
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 4 months ago (2014-08-14 16:40:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/463423003/20001
6 years, 4 months ago (2014-08-14 16:41:09 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-14 17:40:25 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 18:48:27 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180291

Powered by Google App Engine
This is Rietveld 408576698