Remove custom layout from app list SearchBoxView

Remove custom layout from app list SearchBoxView

This CL removes the custom layout from SearchBoxView and uses a BoxLayout
instead. This slightly changes the layout of the app list search box.

BUG=406983
Committed: https://crrev.com/672ae20a4aea8231761149ca4da40c62cc2a517a
Cr-Commit-Position: refs/heads/master@{#292320}

[calamity, 2014-08-25 06:06:17]

screenies on the bug.

[Matt Giuca, 2014-08-26 02:44:14]

lgtm

https://codereview.chromium.org/463403003/diff/20001/ui/app_list/views/search...
File ui/app_list/views/search_box_view.cc (right):

https://codereview.chromium.org/463403003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:105:
search_box_->SetBorder(views::Border::NullBorder());
optional nit: Did this need to move?

(I suppose it feels better coming before the menu button, but probably would
make this patch simpler if it wasn't moving.)

[calamity, 2014-08-26 04:06:31]

https://codereview.chromium.org/463403003/diff/20001/ui/app_list/views/search...
File ui/app_list/views/search_box_view.cc (right):

https://codereview.chromium.org/463403003/diff/20001/ui/app_list/views/search...
ui/app_list/views/search_box_view.cc:105:
search_box_->SetBorder(views::Border::NullBorder());
On 2014/08/26 02:44:14, Matt Giuca wrote:
> optional nit: Did this need to move?
> 
> (I suppose it feels better coming before the menu button, but probably would
> make this patch simpler if it wasn't moving.)

Yeah, it does. Child order matters for BoxLayout. This will lay the speech
button to the right of the menu button if it gets enabled on non-CrOS.

[calamity, 2014-08-26 04:06:37]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-08-26 04:08:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/463403003/20001

[commit-bot: I haz the power, 2014-08-26 04:30:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46187)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/51455)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-26 04:32:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 04:32:32]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46196)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[calamity, 2014-08-28 02:33:48]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-08-28 02:34:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/463403003/40001

[commit-bot: I haz the power, 2014-08-28 03:37:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-28 04:28:53]

Committed patchset #3 (id:40001) as 9c5048c14413ee7b7f342da3ef760d737c2d6180

[commit-bot: I haz the power, 2014-09-10 02:57:31]

Patchset 3 (id:??) landed as
https://crrev.com/672ae20a4aea8231761149ca4da40c62cc2a517a
Cr-Commit-Position: refs/heads/master@{#292320}