Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 463373003: Cast: Fix use after free in a testing tool (Closed)

Created:
6 years, 4 months ago by Alpha Left Google
Modified:
6 years, 4 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cast: Fix use after free in a testing tool cast_simulator should call .Pass() to pass the PacketPipe for simulation. TBR=miu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289226

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M media/cast/test/simulator.cc View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Alpha Left Google
6 years, 4 months ago (2014-08-13 06:12:21 UTC) #1
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 4 months ago (2014-08-13 06:12:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/463373003/1
6 years, 4 months ago (2014-08-13 06:13:54 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-13 07:35:48 UTC) #4
commit-bot: I haz the power
Change committed as 289226
6 years, 4 months ago (2014-08-13 09:15:37 UTC) #5
miu
6 years, 4 months ago (2014-08-13 22:33:45 UTC) #6
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/463373003/diff/1/media/cast/test/simulator.cc
File media/cast/test/simulator.cc (right):

https://codereview.chromium.org/463373003/diff/1/media/cast/test/simulator.cc...
media/cast/test/simulator.cc:286: ipp.NewBuffer(128 * 1024).Pass(),
Huh.  Weird.  I'm surprised it compiled the way it was.

Powered by Google App Engine
This is Rietveld 408576698