Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 463353004: Fix install-build-deps-android for Trusty (Closed)

Created:
6 years, 4 months ago by Erik Corry Chromium.org
Modified:
6 years, 4 months ago
Reviewers:
johnme
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix install-build-deps-android for Trusty BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290646

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/install-build-deps-android.sh View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
johnme
LGTM with nit - thanks! https://codereview.chromium.org/463353004/diff/1/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://codereview.chromium.org/463353004/diff/1/build/install-build-deps-android.sh#newcode50 build/install-build-deps-android.sh:50: # On Trusty-based systems ...
6 years, 4 months ago (2014-08-19 13:07:38 UTC) #1
johnme
The CQ bit was checked by johnme@chromium.org
6 years, 4 months ago (2014-08-19 13:35:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikcorry@chromium.org/463353004/20001
6 years, 4 months ago (2014-08-19 13:36:06 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 20:10:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290646

Powered by Google App Engine
This is Rietveld 408576698