Make bitmaptools executable after downloading it from cloud storage.

Make bitmaptools executable after downloading it from cloud storage.

R=dtu@chromium.org, satyanarayana@google.com
BUG=396317
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289533

[Satyanarayana N H Manyam, 2014-08-13 03:45:41]

LGTM modulo unit tests.

https://codereview.chromium.org/463353002/diff/1/tools/telemetry/telemetry/ut...
File tools/telemetry/telemetry/util/support_binaries.py (right):

https://codereview.chromium.org/463353002/diff/1/tools/telemetry/telemetry/ut...
tools/telemetry/telemetry/util/support_binaries.py:56: if make_executable:
can you update the unittest.

[Dirk Pranke, 2014-08-13 19:56:27]

https://codereview.chromium.org/463353002/diff/1/tools/telemetry/telemetry/ut...
File tools/telemetry/telemetry/util/support_binaries.py (right):

https://codereview.chromium.org/463353002/diff/1/tools/telemetry/telemetry/ut...
tools/telemetry/telemetry/util/support_binaries.py:56: if make_executable:
On 2014/08/13 03:45:41, Satyanarayana N H Manyam wrote:
> can you update the unittest.

Done.

[Dirk Pranke, 2014-08-13 19:56:31]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-08-13 19:57:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dpranke@chromium.org/463353002/20001

[commit-bot: I haz the power, 2014-08-13 19:57:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 19:57:17]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Dirk Pranke, 2014-08-13 20:40:59]

Dave, Tony, can one of you take a look?

[tony, 2014-08-13 20:45:53]

On 2014/08/13 20:40:59, Dirk Pranke wrote:
> Dave, Tony, can one of you take a look?

Wrong Tony (Fixed).

[tonyg, 2014-08-13 21:23:10]

https://codereview.chromium.org/463353002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/util/support_binaries.py (right):

https://codereview.chromium.org/463353002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/util/support_binaries.py:42: def FindPath(binary_name,
platform_name, make_executable=True):
Do we really need the param? This module is about support binaries and the line
below about appending .exe for windows seems to enforce that it is only used as
such. Did you notice a particular case where we don't want to chomd?

[Dirk Pranke, 2014-08-13 21:28:36]

https://codereview.chromium.org/463353002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/util/support_binaries.py (right):

https://codereview.chromium.org/463353002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/util/support_binaries.py:42: def FindPath(binary_name,
platform_name, make_executable=True):
On 2014/08/13 21:23:10, tonyg wrote:
> Do we really need the param? This module is about support binaries and the
line
> below about appending .exe for windows seems to enforce that it is only used
as
> such. Did you notice a particular case where we don't want to chomd?

Oh, I guess you're right. Will fix.

[Dirk Pranke, 2014-08-13 21:35:46]

updated; Tony, please take another look?

[tonyg, 2014-08-13 21:43:11]

lgtm

[Dirk Pranke, 2014-08-13 21:51:18]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-08-13 21:54:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dpranke@chromium.org/463353002/40001

[commit-bot: I haz the power, 2014-08-14 10:26:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-14 12:20:49]

Committed patchset #3 (40001) as 289533