Fix crash due to AbstractFieldElement.computeType.

dart/site/try/poi/poi.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library trydart.poi;
 
 import 'dart:async' show
     Completer,
     Future,
     Stream;
@@ skipping 23 matching lines @@
 import 'package:compiler/implementation/dart2jslib.dart' show
     Compiler,
     Enqueuer,
     QueueFilter,
     WorkItem;
 
 import 'package:compiler/implementation/elements/visitor.dart' show
     ElementVisitor;
 
 import 'package:compiler/implementation/elements/elements.dart' show
+    AbstractFieldElement,
     ClassElement,
     CompilationUnitElement,
     Element,
     ElementCategory,
+    FunctionElement,
     LibraryElement,
     ScopeContainerElement;
 
+import 'package:compiler/implementation/elements/modelx.dart' as modelx;
+
 import 'package:compiler/implementation/dart_types.dart' show
     DartType;
 
 import 'package:compiler/implementation/scanner/scannerlib.dart' show
     EOF_TOKEN,
     IDENTIFIER_TOKEN,
     KEYWORD_TOKEN,
     PartialClassElement,
     PartialElement,
     Token;
@@ skipping 297 matching lines @@
         name: e.getLibraryName(),
         serializeEnclosing: () {
           // The enclosing scope of a library is a scope which contains all the
           // imported names.
           isFirst = true;
           buffer.write('{\n');
           indentationLevel++;
           indented.write('"kind": "imports",\n');
           indented.write('"members": [');
           indentationLevel++;
-          e.importScope.importScope.values.forEach(forEach);
+          importScope(e).importScope.values.forEach(forEach);

[Johnni Winther, 2014/08/19 06:59:29]

Why this change?

[ahe, 2014/08/19 08:41:52]

This code caused a warning. To avoid the warning, I need to import modelx.dart
which I'm not supposed to do. So I moved the use of modelx into methods that
could potentially be added to elements.dart.

           indentationLevel--;
           buffer.write('\n');
           indented.write('],\n');
           // The enclosing scope of the imported names scope is the superclass
           // scope of the current class.
           indented.write('"enclosing": ');
           serializeClassSide(
               currentClass.superclass, isStatic: false, includeSuper: true);
           buffer.write('\n');
           indentationLevel--;
           indented.write('}');
         },
         serializeMembers: () {
           isFirst = true;
-          e.localScope.values.forEach(forEach);
+          localScope(e).values.forEach(forEach);

[Johnni Winther, 2014/08/19 06:59:29]

Ditto.

         });
   }
 
   void visitClassElement(ClassElement e) {
     currentClass = e;
     serializeClassSide(e, isStatic: true);
   }
 
   /// Serializes one of the "sides" a class. The sides of a class are "instance
   /// side" and "class side". These terms are from Smalltalk. The instance side
@@ skipping 66 matching lines @@
         serialize(member);
         isFirst = false;
       });
     });
   }
 
   void visitCompilationUnitElement(CompilationUnitElement e) {
     e.enclosingElement.accept(this);
   }
 
+  void visitAbstractFieldElement(AbstractFieldElement e) {
+    throw new UnsupportedError('AbstractFieldElement cannot be serialized.');
+  }
+
   void serialize(
       Element element,
       {bool omitEnclosing: true,
        void serializeMembers(),
        void serializeEnclosing(),
        String kind,
        String name}) {
+    if (element.isAbstractField) {
+      AbstractFieldElement field = element;
+      FunctionElement getter = field.getter;
+      FunctionElement setter = field.setter;
+      if (getter != null) {
+        serialize(
+            getter,
+            omitEnclosing: omitEnclosing,
+            serializeMembers: serializeMembers,
+            serializeEnclosing: serializeEnclosing,
+            kind: kind,
+            name: name);
+      }
+      if (setter != null) {
+        if (getter != null) {
+          buffer.write(',\n');
+          indented;
+        }
+        serialize(
+            getter,
+            omitEnclosing: omitEnclosing,
+            serializeMembers: serializeMembers,
+            serializeEnclosing: serializeEnclosing,
+            kind: kind,
+            name: name);
+      }
+      return;
+    }
     DartType type;
     int category = element.kind.category;
     if (category == ElementCategory.FUNCTION ||
         category == ElementCategory.VARIABLE ||
         element.isConstructor) {
       type = element.computeType(cachedCompiler);
     }
     if (name == null) {
       name = element.name;
     }
@@ skipping 35 matching lines @@
         serializeEnclosing();
       } else {
         element.enclosingElement.accept(this);
       }
     }
     indentationLevel--;
     buffer.write('\n');
     indented.write('}');
   }
 }
+
+modelx.ScopeX localScope(modelx.LibraryElementX element) => element.localScope;
+
+modelx.ImportScope importScope(modelx.LibraryElementX element) {
+  return element.importScope;
+}