Mac: Fix rounded corners on browser windows on retina display.

Mac: Fix rounded corners on browser windows on retina display.

When a window's bottom corner is covered by a layer on a retina display, the
corner is incorrectly rounded. I added a layer mask to do the corner rounding
ourselves.

BUG=396264
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289811

[erikchen, 2014-08-12 21:45:30]

andresantoso: Please review.

[Andre, 2014-08-12 22:53:28]

Looks OK to me, but I don't know how adding a mask layer affect compositing.
A quick search turned up
http://articles.cocoahope.com/blog/2013/03/06/applying-rounded-corners,
 which suggests an additional rendering pass will happen.
+ccameron who should know more.

https://codereview.chromium.org/463263002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/fast_resize_view.mm (right):

https://codereview.chromium.org/463263002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/fast_resize_view.mm:172: path =
CGPathCreateWithRect(NSRectToCGRect(self.bounds), NULL);
Clear the mask instead, like above.

[erikchen, 2014-08-12 23:01:32]

https://codereview.chromium.org/463263002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/fast_resize_view.mm (right):

https://codereview.chromium.org/463263002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/fast_resize_view.mm:172: path =
CGPathCreateWithRect(NSRectToCGRect(self.bounds), NULL);
On 2014/08/12 22:53:28, Andre wrote:
> Clear the mask instead, like above.

Done.

[Andre, 2014-08-12 23:06:16]

lgtm

https://codereview.chromium.org/463263002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/fast_resize_view.mm (right):

https://codereview.chromium.org/463263002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/fast_resize_view.mm:165: layerMask_ = maskLayer;
optional nit: can do away with maskLayer local variable.
  layerMask_ = [CAShapeLayer layer];
  [self layer].mask = layerMask_

[erikchen, 2014-08-12 23:09:25]

https://codereview.chromium.org/463263002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/fast_resize_view.mm (right):

https://codereview.chromium.org/463263002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/fast_resize_view.mm:165: layerMask_ = maskLayer;
On 2014/08/12 23:06:16, Andre wrote:
> optional nit: can do away with maskLayer local variable.
>   layerMask_ = [CAShapeLayer layer];
>   [self layer].mask = layerMask_

Done.

[erikchen, 2014-08-14 08:16:56]

ccameron: If you care, you should respond. Otherwise I'm just going to forward
this to an OWNER and commit this code.

[ccameron, 2014-08-14 15:36:37]

This LGTM as well. You can feel free to nuke the non-CoreAnimation code from
FastResizeView (drawRect et al) while you're in the neighborhood

[erikchen, 2014-08-14 17:39:04]

I'd prefer to remove the non-CoreAnimation in a different pass.

[erikchen, 2014-08-14 17:39:22]

shess: Looking for an OWNER review of chrome/browser/ui/cocoa

[Scott Hess - ex-Googler, 2014-08-14 18:18:37]

lgtm

[erikchen, 2014-08-14 21:41:11]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-08-14 21:45:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/463263002/80001

[commit-bot: I haz the power, 2014-08-15 03:49:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-15 05:45:53]

Committed patchset #4 (80001) as 289811

[erikchen, 2014-09-10 20:29:15]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/560913004/ by erikchen@chromium.org.

The reason for reverting is: When the download bar is present, the rounded
corners are on the wrong view.

https://code.google.com/p/chromium/issues/detail?id=412580.