bisect-builds.py: Minor bug fixes for blink bisect and better error handling.

bisect-builds.py: Minor bug fixes for blink bisect and better error handling.

This fixes a bug in displaying blink changelog if the range contains git hash and
displays better error message in case of ValueError from json.loads.

BUG=None
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289363

[Robert Sesek, 2014-08-12 20:50:12]

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:1102: (min_chromium_rev, max_chromium_rev, context) =
Bisect(
Why do you need to return context if you're not using it?

[pshenoy, 2014-08-12 21:05:06]

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:1102: (min_chromium_rev, max_chromium_rev, context) =
Bisect(
On 2014/08/12 20:50:11, rsesek wrote:
> Why do you need to return context if you're not using it?

'context' is passed in GetBlinkRevisionForChromiumRevision to access
githash_svn_dict. So we need the 'context' created in Bisect() to get the blink
revision from the corresponding githash value. Earlier it was using the
'context' created in main which was dummy.

[Robert Sesek, 2014-08-12 21:41:24]

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:867: def GetBlinkRevisionForChromiumRevision(self, rev):
Rename self -> context

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:1102: (min_chromium_rev, max_chromium_rev, context) =
Bisect(
On 2014/08/12 21:05:06, pshenoy wrote:
> On 2014/08/12 20:50:11, rsesek wrote:
> > Why do you need to return context if you're not using it?
> 
> 'context' is passed in GetBlinkRevisionForChromiumRevision to access
> githash_svn_dict. So we need the 'context' created in Bisect() to get the
blink
> revision from the corresponding githash value. Earlier it was using the
> 'context' created in main which was dummy.

Ah, makes sense. Why don't we switch from passing all these parameters to
Bisect, which merely passes them to the PathContext constructor, to creating the
context here in Main and then just passing the context to Bisect.

[pshenoy, 2014-08-13 18:13:42]

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:867: def GetBlinkRevisionForChromiumRevision(self, rev):
On 2014/08/12 21:41:24, rsesek wrote:
> Rename self -> context

Done.

https://codereview.chromium.org/463243002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:1102: (min_chromium_rev, max_chromium_rev, context) =
Bisect(
On 2014/08/12 21:41:24, rsesek wrote:
> On 2014/08/12 21:05:06, pshenoy wrote:
> > On 2014/08/12 20:50:11, rsesek wrote:
> > > Why do you need to return context if you're not using it?
> > 
> > 'context' is passed in GetBlinkRevisionForChromiumRevision to access
> > githash_svn_dict. So we need the 'context' created in Bisect() to get the
> blink
> > revision from the corresponding githash value. Earlier it was using the
> > 'context' created in main which was dummy.
> 
> Ah, makes sense. Why don't we switch from passing all these parameters to
> Bisect, which merely passes them to the PathContext constructor, to creating
the
> context here in Main and then just passing the context to Bisect.

Done.

[Robert Sesek, 2014-08-13 20:27:39]

LGTM. Thanks for the cleanup!

[pshenoy, 2014-08-13 20:29:44]

The CQ bit was checked by pshenoy@chromium.org

[commit-bot: I haz the power, 2014-08-13 20:30:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pshenoy@chromium.org/463243002/20001

[commit-bot: I haz the power, 2014-08-13 20:33:03]

Committed patchset #2 (20001) as 289363