Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 463223002: Adding the signed binary for the binary_integrity_analysis unit tests (Closed)

Created:
6 years, 4 months ago by pmonette
Modified:
6 years, 4 months ago
Reviewers:
robertshield
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@grt
Project:
chromium
Visibility:
Public.

Description

Adding the signed binary for the binary_integrity_analysis unit tests This is added in a separated CL because the linux trybots have trouble with checked in binaries. NOTRY=TRUE BUG=402455 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A chrome/test/data/safe_browsing/signed_binary.dll View Binary file 0 comments Download

Messages

Total messages: 13 (0 generated)
pmonette_google.com
Lgtm please!
6 years, 4 months ago (2014-08-12 19:49:00 UTC) #1
robertshield
lgtm
6 years, 4 months ago (2014-08-12 19:49:30 UTC) #2
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 4 months ago (2014-08-12 19:50:44 UTC) #3
robertshield
The CQ bit was unchecked by robertshield@chromium.org
6 years, 4 months ago (2014-08-12 19:50:47 UTC) #4
pmonette_google.com
The CQ bit was checked by pmonette@google.com
6 years, 4 months ago (2014-08-12 19:51:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmonette@google.com/463223002/1
6 years, 4 months ago (2014-08-12 19:54:53 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 00:30:33 UTC) #7
robertshield
Huh, and just to double check, this had the git update-index --chmod+x <file> thing as ...
6 years, 4 months ago (2014-08-13 00:52:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 01:03:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3791)
6 years, 4 months ago (2014-08-13 01:03:03 UTC) #10
pmonette_google.com
The CQ bit was checked by pmonette@google.com
6 years, 4 months ago (2014-08-13 14:16:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmonette@google.com/463223002/1
6 years, 4 months ago (2014-08-13 14:17:02 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 14:18:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (1) as 289287

Powered by Google App Engine
This is Rietveld 408576698