Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 463213002: rebaseline_server: add some live-view.html links to index.html (Closed)

Created:
6 years, 4 months ago by epoger
Modified:
6 years, 4 months ago
Reviewers:
stephana
CC:
reviews_skia.org, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

rebaseline_server: add some live-view.html links to index.html NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/fb261109ec2c33e9236667faf09c13574146e627

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -9 lines) Patch
M gm/rebaseline_server/server.py View 1 6 chunks +60 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
epoger
Stephan, PTAL at patchset 1. You can see it running live here: http://172.24.179.183:8888 I had ...
6 years, 4 months ago (2014-08-12 19:08:24 UTC) #1
stephana
https://codereview.chromium.org/463213002/diff/1/gm/rebaseline_server/server.py File gm/rebaseline_server/server.py (right): https://codereview.chromium.org/463213002/diff/1/gm/rebaseline_server/server.py#newcode117 gm/rebaseline_server/server.py:117: Can you make a note what the next version ...
6 years, 4 months ago (2014-08-13 13:39:26 UTC) #2
epoger
Thanks, Stephan. PTAL. https://codereview.chromium.org/463213002/diff/1/gm/rebaseline_server/server.py File gm/rebaseline_server/server.py (right): https://codereview.chromium.org/463213002/diff/1/gm/rebaseline_server/server.py#newcode117 gm/rebaseline_server/server.py:117: On 2014/08/13 13:39:26, stephana wrote: > ...
6 years, 4 months ago (2014-08-13 14:25:04 UTC) #3
stephana
On 2014/08/13 14:25:04, epoger wrote: > Thanks, Stephan. PTAL. > > https://codereview.chromium.org/463213002/diff/1/gm/rebaseline_server/server.py > File gm/rebaseline_server/server.py ...
6 years, 4 months ago (2014-08-13 14:29:20 UTC) #4
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-13 16:37:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/463213002/20001
6 years, 4 months ago (2014-08-13 16:38:14 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 16:38:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as fb261109ec2c33e9236667faf09c13574146e627

Powered by Google App Engine
This is Rietveld 408576698