Issue 463193002: Random analyzer cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 463193002: Random analyzer cleanup (Closed)

Created:
6 years, 4 months ago by sky

Modified:
6 years, 4 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Random analyzer cleanup Analyze exceptions have been centralized, so I can remove the exceptions from each of the trybot files. --analyzer2 is no longer used by the recipes. BUG=109173 TEST=none R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289094

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -58 lines)			Patch
M	build/gyp_chromium	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	testing/buildbot/chromium_arm.json	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	testing/buildbot/chromium_trybot.json	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	testing/buildbot/chromium_win8_trybot.json	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json&l=80 is still correct?

6 years, 4 months ago (2014-08-12 18:16:29 UTC) #2

sky

That was fixed when I landed support for the new file (https://codereview.chromium.org/463193002/ ). Apparently code ...

6 years, 4 months ago (2014-08-12 19:35:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/463193002/1

6 years, 4 months ago (2014-08-12 19:39:53 UTC) #5

Message was sent while issue was closed.

Change committed as 289094

Expand Messages | Collapse Messages