Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 463183002: Update strings in the avatar bubble (Closed)

Created:
6 years, 4 months ago by guohui
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tfarina, jam, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update strings in the avatar bubble BUG=403018, 403181 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289553

Patch Set 1 : #

Patch Set 2 : updated string per the new spec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
guohui
Hey, could you please review the CL? sky@ for owner review of profile_chooser_view.cc, asvitkine@ for ...
6 years, 4 months ago (2014-08-12 18:02:11 UTC) #1
Alexei Svitkine (slow)
On 2014/08/12 18:02:11, guohui wrote: > Hey, > > could you please review the CL? ...
6 years, 4 months ago (2014-08-12 18:12:26 UTC) #2
Alexei Svitkine (slow)
cocoa code lgtm
6 years, 4 months ago (2014-08-12 18:14:26 UTC) #3
guohui
oops, fixed the description thanks!
6 years, 4 months ago (2014-08-12 18:15:34 UTC) #4
sky
LGTM
6 years, 4 months ago (2014-08-12 19:59:08 UTC) #5
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-12 20:00:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/463183002/40001
6 years, 4 months ago (2014-08-12 20:04:29 UTC) #7
guohui
The CQ bit was unchecked by guohui@chromium.org
6 years, 4 months ago (2014-08-12 20:24:19 UTC) #8
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-13 19:58:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/463183002/60001
6 years, 4 months ago (2014-08-13 19:59:39 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 11:08:18 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 14:14:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (60001) as 289553

Powered by Google App Engine
This is Rietveld 408576698