Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: trunk/src/tools/gn/toolchain.h

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/test_with_scope.cc ('k') | trunk/src/tools/gn/toolchain.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/toolchain.h
===================================================================
--- trunk/src/tools/gn/toolchain.h (revision 232660)
+++ trunk/src/tools/gn/toolchain.h (working copy)
@@ -70,7 +70,7 @@
std::string rspfile_content;
};
- Toolchain(const Settings* settings, const Label& label);
+ Toolchain(const Label& label);
virtual ~Toolchain();
// Item overrides.
@@ -87,6 +87,9 @@
const std::string& environment() const { return environment_; }
void set_environment(const std::string& env) { environment_ = env; }
+ bool is_default() const { return is_default_; }
+ void set_is_default(bool id) { is_default_ = id; }
+
// Specifies build argument overrides that will be set on the base scope. It
// will be as if these arguments were passed in on the command line. This
// allows a toolchain to override the OS type of the default toolchain or
@@ -97,6 +100,7 @@
private:
Tool tools_[TYPE_NUMTYPES];
+ bool is_default_;
Scope::KeyValueMap args_;
std::string environment_;
« no previous file with comments | « trunk/src/tools/gn/test_with_scope.cc ('k') | trunk/src/tools/gn/toolchain.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698