Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: trunk/src/tools/gn/test_with_scope.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/test_with_scope.h ('k') | trunk/src/tools/gn/toolchain.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/test_with_scope.cc
===================================================================
--- trunk/src/tools/gn/test_with_scope.cc (revision 232660)
+++ trunk/src/tools/gn/test_with_scope.cc (working copy)
@@ -6,13 +6,9 @@
TestWithScope::TestWithScope()
: build_settings_(),
- settings_(&build_settings_, std::string()),
- toolchain_(&settings_, Label(SourceDir("//toolchain/"), "default")),
+ toolchain_(Label(SourceDir("//toolchain/"), "tc")),
+ settings_(&build_settings_, &toolchain_, std::string()),
scope_(&settings_) {
- build_settings_.SetBuildDir(SourceDir("//out/Debug/"));
-
- settings_.set_toolchain_label(toolchain_.label());
- settings_.set_is_default(true);
}
TestWithScope::~TestWithScope() {
« no previous file with comments | « trunk/src/tools/gn/test_with_scope.h ('k') | trunk/src/tools/gn/toolchain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698