Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: trunk/src/tools/gn/target.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/target.h ('k') | trunk/src/tools/gn/target_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/target.cc
===================================================================
--- trunk/src/tools/gn/target.cc (revision 232660)
+++ trunk/src/tools/gn/target.cc (working copy)
@@ -57,7 +57,8 @@
} // namespace
Target::Target(const Settings* settings, const Label& label)
- : Item(settings, label),
+ : Item(label),
+ settings_(settings),
output_type_(UNKNOWN),
hard_dep_(false),
external_(false),
@@ -154,9 +155,9 @@
}
// Mark as resolved.
- if (!settings()->build_settings()->target_resolved_callback().is_null()) {
+ if (!settings_->build_settings()->target_resolved_callback().is_null()) {
g_scheduler->ScheduleWork(base::Bind(&TargetResolvedThunk,
- settings()->build_settings()->target_resolved_callback(),
+ settings_->build_settings()->target_resolved_callback(),
this));
}
}
« no previous file with comments | « trunk/src/tools/gn/target.h ('k') | trunk/src/tools/gn/target_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698