Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/tools/gn/setup.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/setup.h ('k') | trunk/src/tools/gn/target.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/setup.cc
===================================================================
--- trunk/src/tools/gn/setup.cc (revision 232660)
+++ trunk/src/tools/gn/setup.cc (working copy)
@@ -202,9 +202,9 @@
Setup::Setup()
: CommonSetup(),
- empty_settings_(&empty_build_settings_, std::string()),
+ empty_toolchain_(Label()),
+ empty_settings_(&empty_build_settings_, &empty_toolchain_, std::string()),
dotfile_scope_(&empty_settings_) {
- empty_settings_.set_toolchain_label(Label());
}
Setup::~Setup() {
« no previous file with comments | « trunk/src/tools/gn/setup.h ('k') | trunk/src/tools/gn/target.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698