Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/tools/gn/settings.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/settings.h ('k') | trunk/src/tools/gn/setup.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/settings.cc
===================================================================
--- trunk/src/tools/gn/settings.cc (revision 232660)
+++ trunk/src/tools/gn/settings.cc (working copy)
@@ -9,9 +9,10 @@
#include "tools/gn/filesystem_utils.h"
Settings::Settings(const BuildSettings* build_settings,
+ const Toolchain* toolchain,
const std::string& output_subdir_name)
: build_settings_(build_settings),
- is_default_(false),
+ toolchain_(toolchain),
import_manager_(),
base_config_(this),
greedy_target_generation_(false) {
« no previous file with comments | « trunk/src/tools/gn/settings.h ('k') | trunk/src/tools/gn/setup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698