Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: trunk/src/tools/gn/ninja_script_target_writer_unittest.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/ninja_script_target_writer.cc ('k') | trunk/src/tools/gn/ninja_target_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/ninja_script_target_writer_unittest.cc
===================================================================
--- trunk/src/tools/gn/ninja_script_target_writer_unittest.cc (revision 232660)
+++ trunk/src/tools/gn/ninja_script_target_writer_unittest.cc (working copy)
@@ -21,7 +21,7 @@
SourceFile("//out/Debug/gen/{{source_name_part}}.cc"));
std::ostringstream out;
- NinjaScriptTargetWriter writer(&target, setup.toolchain(), out);
+ NinjaScriptTargetWriter writer(&target, out);
FileTemplate output_template = writer.GetOutputTemplate();
@@ -42,7 +42,7 @@
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
std::ostringstream out;
- NinjaScriptTargetWriter writer(&target, setup.toolchain(), out);
+ NinjaScriptTargetWriter writer(&target, out);
std::vector<std::string> args;
args.push_back("-i");
@@ -88,7 +88,7 @@
"/usr/bin/python")));
std::ostringstream out;
- NinjaScriptTargetWriter writer(&target, setup.toolchain(), out);
+ NinjaScriptTargetWriter writer(&target, out);
writer.Run();
const char expected_linux[] =
@@ -107,7 +107,7 @@
" source = ../../foo/input2.txt\n"
" source_name_part = input2\n"
"\n"
- "build obj/foo/bar.stamp: stamp input1.out input2.out\n";
+ "build obj/foo/bar.stamp: tc_stamp input1.out input2.out\n";
std::string out_str = out.str();
#if defined(OS_WIN)
@@ -125,7 +125,7 @@
setup.settings()->set_target_os(Settings::WIN);
std::ostringstream out;
- NinjaScriptTargetWriter writer(&target, setup.toolchain(), out);
+ NinjaScriptTargetWriter writer(&target, out);
writer.Run();
// TODO(brettw) I think we'll need to worry about backslashes here
@@ -151,7 +151,7 @@
" source = ../../foo/input2.txt\n"
" source_name_part = input2\n"
"\n"
- "build obj/foo/bar.stamp: stamp input1.out input2.out\n";
+ "build obj/foo/bar.stamp: tc_stamp input1.out input2.out\n";
std::string out_str = out.str();
#if defined(OS_WIN)
std::replace(out_str.begin(), out_str.end(), '\\', '/');
« no previous file with comments | « trunk/src/tools/gn/ninja_script_target_writer.cc ('k') | trunk/src/tools/gn/ninja_target_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698