Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/tools/gn/ninja_helper_unittest.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/ninja_helper.cc ('k') | trunk/src/tools/gn/ninja_script_target_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/ninja_helper_unittest.cc
===================================================================
--- trunk/src/tools/gn/ninja_helper_unittest.cc (revision 232660)
+++ trunk/src/tools/gn/ninja_helper_unittest.cc (working copy)
@@ -17,10 +17,9 @@
public:
HelperSetterUpper()
: build_settings(),
- settings(&build_settings, std::string()),
- toolchain(&settings, Label(SourceDir("//"), "tc")),
+ toolchain(Label(SourceDir("//"), "tc")),
+ settings(&build_settings, &toolchain, std::string()),
target(&settings, Label(SourceDir("//tools/gn/"), "name")) {
- settings.set_toolchain_label(toolchain.label());
settings.set_target_os(Settings::WIN);
// Output going to "out/Debug".
« no previous file with comments | « trunk/src/tools/gn/ninja_helper.cc ('k') | trunk/src/tools/gn/ninja_script_target_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698