Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: trunk/src/tools/gn/ninja_group_target_writer.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/ninja_group_target_writer.h ('k') | trunk/src/tools/gn/ninja_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/ninja_group_target_writer.cc
===================================================================
--- trunk/src/tools/gn/ninja_group_target_writer.cc (revision 232660)
+++ trunk/src/tools/gn/ninja_group_target_writer.cc (working copy)
@@ -8,9 +8,8 @@
#include "tools/gn/string_utils.h"
NinjaGroupTargetWriter::NinjaGroupTargetWriter(const Target* target,
- const Toolchain* toolchain,
std::ostream& out)
- : NinjaTargetWriter(target, toolchain, out) {
+ : NinjaTargetWriter(target, out) {
}
NinjaGroupTargetWriter::~NinjaGroupTargetWriter() {
@@ -22,7 +21,7 @@
out_ << std::endl << "build ";
path_output_.WriteFile(out_, helper_.GetTargetOutputFile(target_));
out_ << ": "
- << helper_.GetRulePrefix(target_->settings())
+ << helper_.GetRulePrefix(target_->settings()->toolchain())
<< "stamp";
const LabelTargetVector& deps = target_->deps();
« no previous file with comments | « trunk/src/tools/gn/ninja_group_target_writer.h ('k') | trunk/src/tools/gn/ninja_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698