Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: trunk/src/tools/gn/ninja_copy_target_writer.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/tools/gn/ninja_copy_target_writer.cc
===================================================================
--- trunk/src/tools/gn/ninja_copy_target_writer.cc (revision 232660)
+++ trunk/src/tools/gn/ninja_copy_target_writer.cc (working copy)
@@ -9,9 +9,8 @@
#include "tools/gn/string_utils.h"
NinjaCopyTargetWriter::NinjaCopyTargetWriter(const Target* target,
- const Toolchain* toolchain,
std::ostream& out)
- : NinjaTargetWriter(target, toolchain, out) {
+ : NinjaTargetWriter(target, out) {
}
NinjaCopyTargetWriter::~NinjaCopyTargetWriter() {
@@ -23,7 +22,8 @@
std::vector<OutputFile> output_files;
- std::string rule_prefix = helper_.GetRulePrefix(target_->settings());
+ std::string rule_prefix =
+ helper_.GetRulePrefix(target_->settings()->toolchain());
for (size_t i = 0; i < target_->sources().size(); i++) {
const SourceFile& input_file = target_->sources()[i];
« no previous file with comments | « trunk/src/tools/gn/ninja_copy_target_writer.h ('k') | trunk/src/tools/gn/ninja_copy_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698