Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: trunk/src/tools/gn/item.h

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/input_conversion.cc ('k') | trunk/src/tools/gn/item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/item.h
===================================================================
--- trunk/src/tools/gn/item.h (revision 232660)
+++ trunk/src/tools/gn/item.h (working copy)
@@ -11,7 +11,6 @@
class Config;
class ItemNode;
-class Settings;
class Target;
class Toolchain;
@@ -19,11 +18,9 @@
// graph.
class Item {
public:
- Item(const Settings* settings, const Label& label);
+ Item(const Label& label);
virtual ~Item();
- const Settings* settings() const { return settings_; }
-
// This is guaranteed to never change after construction so this can be
// accessed from any thread with no locking once the item is constructed.
const Label& label() const { return label_; }
@@ -52,7 +49,6 @@
virtual void OnResolved() {}
private:
- const Settings* settings_;
Label label_;
ItemNode* item_node_;
« no previous file with comments | « trunk/src/tools/gn/input_conversion.cc ('k') | trunk/src/tools/gn/item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698