Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: trunk/src/tools/gn/ninja_helper.h

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « trunk/src/tools/gn/ninja_group_target_writer.cc ('k') | trunk/src/tools/gn/ninja_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_NINJA_HELPER_H_ 5 #ifndef TOOLS_GN_NINJA_HELPER_H_
6 #define TOOLS_GN_NINJA_HELPER_H_ 6 #define TOOLS_GN_NINJA_HELPER_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 #include <string> 9 #include <string>
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 // Returns the filename produced by the given output. 46 // Returns the filename produced by the given output.
47 // 47 //
48 // Some targets make multiple files (like a .dll and an import library). This 48 // Some targets make multiple files (like a .dll and an import library). This
49 // function returns the name of the file other targets should depend on and 49 // function returns the name of the file other targets should depend on and
50 // link to (so in this example, the import library). 50 // link to (so in this example, the import library).
51 OutputFile GetTargetOutputFile(const Target* target) const; 51 OutputFile GetTargetOutputFile(const Target* target) const;
52 52
53 // Returns the prefix for rules on the given toolchain. We need this to 53 // Returns the prefix for rules on the given toolchain. We need this to
54 // disambiguate a given rule for each toolchain. 54 // disambiguate a given rule for each toolchain.
55 std::string GetRulePrefix(const Settings* settings) const; 55 std::string GetRulePrefix(const Toolchain* toolchain) const;
56 56
57 // Returns the name of the rule name for the given toolchain and file/target 57 // Returns the name of the rule name for the given toolchain and file/target
58 // type. Returns the empty string for source files with no command. 58 // type. Returns the empty string for source files with no command.
59 std::string GetRuleForSourceType(const Settings* settings, 59 std::string GetRuleForSourceType(const Settings* settings,
60 const Toolchain* toolchain,
60 SourceFileType type) const; 61 SourceFileType type) const;
61 62
62 // Returns the relative directory in either slashes or the system separator 63 // Returns the relative directory in either slashes or the system separator
63 // from the ninja directory (e.g. "out/Debug") to the source root (e.g. 64 // from the ninja directory (e.g. "out/Debug") to the source root (e.g.
64 // "../.."). It has no terminating slash. 65 // "../.."). It has no terminating slash.
65 const std::string& build_to_src_no_last_slash() const { 66 const std::string& build_to_src_no_last_slash() const {
66 return build_to_src_no_last_slash_; 67 return build_to_src_no_last_slash_;
67 } 68 }
68 const std::string& build_to_src_system_no_last_slash() const { 69 const std::string& build_to_src_system_no_last_slash() const {
69 return build_to_src_system_no_last_slash_; 70 return build_to_src_system_no_last_slash_;
70 } 71 }
71 72
72 private: 73 private:
73 const BuildSettings* build_settings_; 74 const BuildSettings* build_settings_;
74 75
75 std::string build_to_src_no_last_slash_; 76 std::string build_to_src_no_last_slash_;
76 std::string build_to_src_system_no_last_slash_; 77 std::string build_to_src_system_no_last_slash_;
77 78
78 DISALLOW_COPY_AND_ASSIGN(NinjaHelper); 79 DISALLOW_COPY_AND_ASSIGN(NinjaHelper);
79 }; 80 };
80 81
81 #endif // TOOLS_GN_NINJA_HELPER_H_ 82 #endif // TOOLS_GN_NINJA_HELPER_H_
OLDNEW
« no previous file with comments | « trunk/src/tools/gn/ninja_group_target_writer.cc ('k') | trunk/src/tools/gn/ninja_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698