Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: trunk/src/tools/gn/ninja_binary_target_writer.h

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « trunk/src/tools/gn/item.cc ('k') | trunk/src/tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_ 5 #ifndef TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_
6 #define TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_ 6 #define TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "tools/gn/ninja_target_writer.h" 9 #include "tools/gn/ninja_target_writer.h"
10 #include "tools/gn/toolchain.h" 10 #include "tools/gn/toolchain.h"
11 11
12 // Writes a .ninja file for a binary target type (an executable, a shared 12 // Writes a .ninja file for a binary target type (an executable, a shared
13 // library, or a static library). 13 // library, or a static library).
14 class NinjaBinaryTargetWriter : public NinjaTargetWriter { 14 class NinjaBinaryTargetWriter : public NinjaTargetWriter {
15 public: 15 public:
16 NinjaBinaryTargetWriter(const Target* target, 16 NinjaBinaryTargetWriter(const Target* target, std::ostream& out);
17 const Toolchain* toolchain,
18 std::ostream& out);
19 virtual ~NinjaBinaryTargetWriter(); 17 virtual ~NinjaBinaryTargetWriter();
20 18
21 virtual void Run() OVERRIDE; 19 virtual void Run() OVERRIDE;
22 20
23 private: 21 private:
24 typedef std::set<OutputFile> OutputFileSet; 22 typedef std::set<OutputFile> OutputFileSet;
25 23
26 void WriteCompilerVars(); 24 void WriteCompilerVars();
27 void WriteSources(std::vector<OutputFile>* object_files); 25 void WriteSources(std::vector<OutputFile>* object_files);
28 void WriteLinkerStuff(const std::vector<OutputFile>& object_files); 26 void WriteLinkerStuff(const std::vector<OutputFile>& object_files);
(...skipping 30 matching lines...) Expand all
59 void WriteImplicitDependencies( 57 void WriteImplicitDependencies(
60 const std::vector<const Target*>& non_linkable_deps); 58 const std::vector<const Target*>& non_linkable_deps);
61 59
62 Toolchain::ToolType tool_type_; 60 Toolchain::ToolType tool_type_;
63 61
64 DISALLOW_COPY_AND_ASSIGN(NinjaBinaryTargetWriter); 62 DISALLOW_COPY_AND_ASSIGN(NinjaBinaryTargetWriter);
65 }; 63 };
66 64
67 #endif // TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_ 65 #endif // TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_
68 66
OLDNEW
« no previous file with comments | « trunk/src/tools/gn/item.cc ('k') | trunk/src/tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698