Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(178)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/http/tests/resources/dpr.php
Issue
46313002
:
Support the DPR header for client hints. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: with cache tests
Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/http/tests/cache/image-with-dpr-header-cached.html
LayoutTests/http/tests/cache/image-with-dpr-header-cached-expected.html
LayoutTests/http/tests/images/image-with-dpr-header.html
LayoutTests/http/tests/images/image-with-dpr-header-expected.html
LayoutTests/http/tests/resources/dpr.php
Source/core/fetch/ImageResource.h
Source/core/fetch/ImageResource.cpp
Source/core/rendering/RenderImage.cpp
Source/platform/RuntimeEnabledFeatures.in
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/http/tests/images/image-with-dpr-header-expected.html
('k') |
Source/core/fetch/ImageResource.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<?php
2
$name = $_GET['name'];
3
$mimeType = $_GET['mimeType'];
4
$dpr = $_GET['dpr'];
5
6
header('Content-Type: ' . $mimeType);
7
header('Content-Length: ' . filesize($name));
8
if (isset($_GET['expires']))
9
header('Cache-control: max-age=0');
10
else
11
header('Cache-control: max-age=86400');
12
header('ETag: dprimage');
13
14
if ($_SERVER['HTTP_IF_NONE_MATCH'] == 'dprimage') {
15
header('HTTP/1.1 304 Not Modified');
16
exit;
17
}
18
19
header('DPR: '. $dpr);
20
21
readfile($name);
OLD
NEW
« no previous file with comments
|
« LayoutTests/http/tests/images/image-with-dpr-header-expected.html
('k') |
Source/core/fetch/ImageResource.h »
('j') |
no next file with comments »
Issue 46313002: Support the DPR header for client hints. (Closed)
Created 7 years, 1 month ago by cbiesinger
Modified 7 years, 1 month ago
Reviewers: pdr., pdr
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 8
This is Rietveld
408576698
Chromium Code Reviews
Issue 46313002:
Support the DPR header for client hints. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk