LayoutTests/http/tests/resources/dpr.php - Issue 46313002: Support the DPR header for client hints.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/resources/dpr.php

Issue 46313002: Support the DPR header for client hints. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?php

	2 $name = $_GET['name'];

	3 $mimeType = $_GET['mimeType'];

	4 $dpr = $_GET['dpr'];

	5

	6 $file = fopen($name, "rb");

	7 if (!$file)

	8 die("Cannot open file.");

	9

	10 header("Content-Type: " . $mimeType);

	11 header("Content-Length: " . filesize($name));

	12 header("DPR: ". $dpr);
	pdr. 2013/10/26 01:26:31 Should the header name be "DPR" or "CH-DPR"? I th Should the header name be "DPR" or "CH-DPR"? I think the spec means to actually use "CH-DPR" ("3.1. The Client Hints Request Header Field".) pdr 2013/10/27 21:04:39 For posterity, I was just mixed up here. DPR is th Show quoted text On 2013/10/26 01:26:31, pdr wrote: > Should the header name be "DPR" or "CH-DPR"? > > I think the spec means to actually use "CH-DPR" ("3.1. The Client Hints Request > Header Field".) For posterity, I was just mixed up here. DPR is the correct value after all.
	13

	14 echo(fread($file, filesize($name)));

	15 flush();

	16 ob_flush();

	17 fclose($file);

	18 ?>

OLD	NEW