Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 463123003: Cleanup namespace usage in Source/core/rendering (Closed)

Created:
6 years, 4 months ago by Sunil Ratnu
Modified:
6 years, 4 months ago
Reviewers:
tkent, abarth-chromium
CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr., rwlbuis, rune+blink, Stephen Chennney, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cleanup namespace usage in Source/core/rendering. - Remove unnecessary blink:: prefixes - Make blank lines consistent Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180219

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -100 lines) Patch
M Source/core/rendering/FloatingObjects.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/GraphicsContextAnnotator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 8 chunks +15 lines, -15 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 18 chunks +41 lines, -41 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/ShapeOutsideInfo.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/FillLayer.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/FillLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Sunil Ratnu
Please review this. Thanks!
6 years, 4 months ago (2014-08-12 16:14:20 UTC) #1
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-12 17:37:12 UTC) #2
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 4 months ago (2014-08-12 17:37:27 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-12 17:37:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/463123003/20001
6 years, 4 months ago (2014-08-12 17:38:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 19:39:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 20:09:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22358)
6 years, 4 months ago (2014-08-12 20:09:09 UTC) #8
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-13 09:55:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/463123003/40001
6 years, 4 months ago (2014-08-13 09:56:03 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 11:03:33 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 11:44:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22516)
6 years, 4 months ago (2014-08-13 11:44:13 UTC) #13
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-14 00:37:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/463123003/40001
6 years, 4 months ago (2014-08-14 00:38:21 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 00:40:01 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 180219

Powered by Google App Engine
This is Rietveld 408576698