Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 463093002: Show a separator in the combobox of Bookmark Bubble. (Closed)

Created:
6 years, 4 months ago by Gaja
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Show a separator in the combobox of Bookmark Bubble. There should be a separator in folder popup button to differenciate "Choose another folder" button from already available bookmark folders. BUG=237697 R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Gaja
6 years, 4 months ago (2014-08-12 11:23:30 UTC) #1
Gaja
PTAL
6 years, 4 months ago (2014-08-12 11:24:02 UTC) #2
Alexei Svitkine (slow)
LGTM
6 years, 4 months ago (2014-08-12 15:12:18 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 4 months ago (2014-08-12 16:07:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gajendra.n@samsung.com/463093002/1
6 years, 4 months ago (2014-08-12 16:09:26 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-12 17:57:12 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 18:34:54 UTC) #7
Message was sent while issue was closed.
Change committed as 289033

Powered by Google App Engine
This is Rietveld 408576698