Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issue 463053002: Flag for rollback feature switched to covering by default state. (Closed)

Created:
6 years, 4 months ago by merkulova
Modified:
6 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Flag for rollback feature switched to covering by default state. BUG=402453 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289234

Patch Set 1 #

Patch Set 2 : Tests adapted for flag add. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/browser/chromeos/login/reset_browsertest.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
merkulova
6 years, 4 months ago (2014-08-12 09:27:57 UTC) #1
dzhioev (left Google)
On 2014/08/12 09:27:57, merkulova wrote: LGTM
6 years, 4 months ago (2014-08-12 16:01:58 UTC) #2
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 4 months ago (2014-08-12 16:05:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/463053002/1
6 years, 4 months ago (2014-08-12 16:07:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 17:30:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 18:11:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/3354)
6 years, 4 months ago (2014-08-12 18:11:25 UTC) #7
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 4 months ago (2014-08-13 08:22:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/463053002/20001
6 years, 4 months ago (2014-08-13 08:29:35 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 09:45:44 UTC) #10
Message was sent while issue was closed.
Change committed as 289234

Powered by Google App Engine
This is Rietveld 408576698