Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 463043004: Whitelist Qualcomm GPUs for GPU rasterization on Android 4.4 (Closed)

Created:
6 years, 4 months ago by ajuma
Modified:
6 years, 4 months ago
Reviewers:
vangelis, Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org, aelias_OOO_until_Jul13, Vangelis Kokkevis, ernstm
Project:
chromium
Visibility:
Public.

Description

Whitelist Qualcomm GPUs for GPU rasterization on Android 4.4 This expands the GPU rasterization device whitelist to include all Android 4.4 devices with Qualcomm GPUs. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289301

Patch Set 1 #

Patch Set 2 : Try to fix test failures #

Total comments: 2

Patch Set 3 : Fix nit #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 2 4 4 chunks +33 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ajuma
6 years, 4 months ago (2014-08-12 14:27:19 UTC) #1
vangelis
On 2014/08/12 14:27:19, ajuma wrote: LGTM
6 years, 4 months ago (2014-08-12 15:01:05 UTC) #2
ajuma
The gl_vendor check seems to be causing a bunch of GPU test failures across platforms. ...
6 years, 4 months ago (2014-08-12 18:28:29 UTC) #3
Zhenyao Mo
LGTM I don't know what's going on with your first CL. In theory the first ...
6 years, 4 months ago (2014-08-12 21:31:49 UTC) #4
Zhenyao Mo
By the way, https://codereview.chromium.org/452293002/ just landed, so you need to modify the entries accordingly.
6 years, 4 months ago (2014-08-12 21:42:47 UTC) #5
ajuma
Filed http://crbug.com/403057 for the difference in behavior between the first and second patch sets. On ...
6 years, 4 months ago (2014-08-13 14:58:57 UTC) #6
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 4 months ago (2014-08-13 14:59:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/463043004/100001
6 years, 4 months ago (2014-08-13 14:59:42 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 15:52:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (100001) as 289301

Powered by Google App Engine
This is Rietveld 408576698