Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: Source/devtools/front_end/ui/DataGrid.js

Issue 463043002: DevTools: DataGrid: corner td should also have regular td style. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/DataGrid.js
diff --git a/Source/devtools/front_end/ui/DataGrid.js b/Source/devtools/front_end/ui/DataGrid.js
index 6c1a8e935e7e3afef903a5b52915bc0ecb98013a..fc2db0f00c39898790a3596ae3a3891c20add71a 100644
--- a/Source/devtools/front_end/ui/DataGrid.js
+++ b/Source/devtools/front_end/ui/DataGrid.js
@@ -1176,11 +1176,9 @@ WebInspector.DataGridNode.prototype = {
{
this._element.removeChildren();
var columnsArray = this.dataGrid._visibleColumnsArray;
- for (var i = 0; i < columnsArray.length; ++i) {
- var cell = this.createCell(columnsArray[i].identifier);
- this._element.appendChild(cell);
- }
- this._element.createChild("td", "corner");
+ for (var i = 0; i < columnsArray.length; ++i)
+ this._element.appendChild(this.createCell(columnsArray[i].identifier));
+ this._element.appendChild(this._createTDWithClass("corner"));
},
get data()
@@ -1320,17 +1318,25 @@ WebInspector.DataGridNode.prototype = {
},
/**
- * @param {string} columnIdentifier
+ * @param {string} className
* @return {!Element}
*/
- createTD: function(columnIdentifier)
+ _createTDWithClass: function(className)
{
- var cell = document.createElement("td");
- cell.className = columnIdentifier + "-column";
+ var cell = document.createElementWithClass("td", className);
var cellClass = this.dataGrid._cellClass;
if (cellClass)
cell.classList.add(cellClass);
+ return cell;
+ },
+ /**
+ * @param {string} columnIdentifier
+ * @return {!Element}
+ */
+ createTD: function(columnIdentifier)
+ {
+ var cell = this._createTDWithClass(columnIdentifier + "-column");
cell.columnIdentifier_ = columnIdentifier;
var alignment = this.dataGrid._columns[columnIdentifier].align;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698