Issue 463033002: Do not coalesce events from different threads having same name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 463033002: Do not coalesce events from different threads having same name (Closed)

Created:
6 years, 4 months ago by yurys

Modified:
6 years, 4 months ago

Reviewers:
eustas, alph

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Do not coalesce events from different threads having same name There are may well be several threads with same name, e.g. all worker threads will be called "WebCore: Worker". Such threads should be displayed as separate threads on tracing based timeline. BUG=401895 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180049

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -13 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	Source/devtools/front_end/timeline/TracingTimelineModel.js	View		5 chunks	+25 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/463033002/1

6 years, 4 months ago (2014-08-12 08:07:16 UTC) #4

Message was sent while issue was closed.

Change committed as 180049

Expand Messages | Collapse Messages