Fix chrome upload with content uri

base/files/file_path_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
@@ skipping 1210 matching lines @@
     { FPL("foo"), FPL("foo/") },
     { FPL("foo/"), FPL("foo/") }
   };
   for (size_t i = 0; i < arraysize(cases); ++i) {
     FilePath input = FilePath(cases[i].input).NormalizePathSeparators();
     FilePath expected = FilePath(cases[i].expected).NormalizePathSeparators();
     EXPECT_EQ(expected.value(), input.AsEndingWithSeparator().value());
   }
 }
 
+#if defined(OS_ANDROID)
+TEST_F(FilePathTest, ContentUriTest) {
+  const struct UnaryBooleanTestData cases[] = {
+    { FPL("content://foo.bar"),    true },
+    { FPL("content://foo.bar/"),   true },
+    { FPL("content://foo/bar"),    true },
+    { FPL("CoNTenT://foo.bar"),    true },

[jar (doing other things), 2013/11/13 01:03:28]

Since you wrote code to distinguish the presence of a first letter... you
probably should have the test:


{ FPL("content://3foo/bar"),    false},
{ FPL("content://_foo/bar"),    false},

As noted... I wasn't sure why you wanted to define it this way.... but that
seemed to be an intentional set of cases.

[qinmin, 2013/11/13 23:42:43]

added the above tests, since the first letter check is now removed, changed the
expected result from these tests.
The app will handle invalid content uris.

On 2013/11/13 01:03:28, jar wrote:

+    { FPL("content://"),           false },
+    { FPL(".. "),                  false },
+    { FPL("foo.bar"),              false },
+    { FPL("content:foo.bar"),      false },
+    { FPL("content:/foo.ba"),      false },
+    { FPL("content:/dir/foo.bar"), false },
+    { FPL("content:///foo.bar"),   false },
+    { FPL("content: //foo.bar"),   false },
+    { FPL("content%2a%2f%2f"),     false },
+  };
+
+  for (size_t i = 0; i < arraysize(cases); ++i) {
+    FilePath input(cases[i].input);
+    bool observed = input.IsContentUri();
+    EXPECT_EQ(cases[i].expected, observed) <<
+              "i: " << i << ", input: " << input.value();
+  }
+}
+#endif
+
 }  // namespace base